bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Bugfix synchronization collisions with database when the object entry already exists #241

Closed jujaga closed 8 months ago

jujaga commented 8 months ago

Description

Synchronization was attempting to perform an insertion operation when the object already exists and collides with the database. It was not going down the right branch of sync code.

Synchronization does not work at this time for objects that already exist in COMS, and will impact clients' ability to retrieve up to date statuses of their S3 buckets.

SHOWCASE-3498 SHOWCASE-3503

Types of changes

Bug fix (non-breaking change which fixes an issue)

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Further comments

codeclimate[bot] commented 8 months ago

Code Climate has analyzed commit 3576cabf and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.3% (0.5% change).

View more on Code Climate.

github-actions[bot] commented 8 months ago

Coverage Report

Totals Coverage
Statements: 59.6% ( 2801 / 4700 )
Methods: 50% ( 319 / 638 )
Lines: 66.33% ( 1684 / 2539 )
Branches: 52.4% ( 798 / 1523 )