bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Modify getObject CORP header to use cross-origin policy #242

Closed jujaga closed 9 months ago

jujaga commented 9 months ago

Description

There are use cases where COMS is being used as a way to directly reference and embed content into a 3rd-party webpage. The default helmet CORP policy of same-origin was too restrictive for this specific endpoint.

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3509

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

Further comments

github-actions[bot] commented 9 months ago

Coverage Report

Totals Coverage
Statements: 59.6% ( 2802 / 4701 )
Methods: 50% ( 319 / 638 )
Lines: 66.34% ( 1685 / 2540 )
Branches: 52.4% ( 798 / 1523 )
codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit dc254b91 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.3% (0.0% change).

View more on Code Climate.