bcgov / common-object-management-service

A microservice for managing access control to S3 Objects

https://bcgov.github.io/common-object-management-service/

Apache License 2.0

6 stars 9 forks source link

Make object search filters on version attributes work when combined (intersect) #243

Closed TimCsaky closed 10 months ago

TimCsaky commented 10 months ago

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3511

Modifier used by searchObjecs service, to ensure filters for version attributes isLatest, deleted and mimetype work together.

Description

Ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3511

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

github-actions[bot] commented 10 months ago

Coverage Report

Totals
Statements:	59.76% ( 2802 / 4689 )
Methods:	50.32% ( 319 / 634 )
Lines:	66.5% ( 1685 / 2534 )
Branches:	52.47% ( 798 / 1521 )

codeclimate[bot] commented 10 months ago

Code Climate has analyzed commit 3d410124 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.4% (0.1% change).

View more on Code Climate.