bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Return full object permissions in object search #248

Closed TimCsaky closed 8 months ago

TimCsaky commented 8 months ago

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3539 if user does objectSearch with permissions=true, return all permission details for each object

note: the objectSearch query (specifically the hasPermission() modifier has become unwiedly and not written efficiently. The changes in this pr accommodate for that.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Documentation (non-breaking change with enhancements to documentation)

Checklist

Further comments

codeclimate[bot] commented 8 months ago

Code Climate has analyzed commit caed857b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.5% (0.0% change).

View more on Code Climate.

github-actions[bot] commented 8 months ago

Coverage Report

Totals Coverage
Statements: 59.81% ( 2811 / 4700 )
Methods: 50.47% ( 321 / 636 )
Lines: 66.54% ( 1690 / 2540 )
Branches: 52.49% ( 800 / 1524 )