bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Revert searchObject permission attribute API structure #250

Closed jujaga closed 9 months ago

jujaga commented 9 months ago

Description

This PR reverts the API shape changes done in #248 while preserving the user context scoping logic added. The API shape change introduced in the previous PR was unnecessary as it introduced extra unnecessary object parsing overhead that does not yield an improvement in permission conveyance that the original spec was not able to already support.

Reverts SHOWCASE-3539

Types of changes

Bug fix (non-breaking change which fixes an issue)

Documentation (non-breaking change with enhancements to documentation) Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Further comments

github-actions[bot] commented 9 months ago

Coverage Report

Totals Coverage
Statements: 59.86% ( 2815 / 4703 )
Methods: 50.55% ( 322 / 637 )
Lines: 66.55% ( 1691 / 2541 )
Branches: 52.59% ( 802 / 1525 )