bcgov / common-object-management-service

A microservice for managing access control to S3 Objects

https://bcgov.github.io/common-object-management-service/

Apache License 2.0

6 stars 9 forks source link

Bug fix: Sync public flag on object #260

Closed TimCsaky closed 6 months ago

TimCsaky commented 6 months ago

Description

bug existed where public file would become non-public after sync. logic we want is:

if object is marked as public in s3 then mark as public in coms db.
if s3 public attribute is false or undefined, keep coms public status.

Types of changes

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codeclimate[bot] commented 6 months ago

Code Climate has analyzed commit 7cf7aef2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (0.0% change).

View more on Code Climate.

github-actions[bot] commented 6 months ago

Coverage Report

Totals
Statements:	61.11% ( 3049 / 4989 )
Methods:	50.99% ( 335 / 657 )
Lines:	68.15% ( 1832 / 2688 )
Branches:	53.65% ( 882 / 1644 )