bcgov / common-object-management-service

A microservice for managing access control to S3 Objects
https://bcgov.github.io/common-object-management-service/
Apache License 2.0
6 stars 9 forks source link

Accept array of permCodes for user creating a bucket #264

Closed TimCsaky closed 5 months ago

TimCsaky commented 5 months ago

Description

This code change allows createBucket to be called with an additional 'permCodes' parameter. The current user will be granted those permissions, where previously they always received all permissions. https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3704

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

Further comments

github-actions[bot] commented 5 months ago

Coverage Report

Totals Coverage
Statements: 61.12% ( 3051 / 4992 )
Methods: 50.99% ( 335 / 657 )
Lines: 68.14% ( 1831 / 2687 )
Branches: 53.7% ( 885 / 1648 )
codeclimate[bot] commented 5 months ago

Code Climate has analyzed commit d6d71fdd and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 71.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (0.0% change).

View more on Code Climate.