Allow Content-Disposition types other than attachment

[norrisng-bc]

Description

Content-Disposition types other than attachment are now allowed.

The following are still required, however:

• A Content-Disposition header
• A disposition type of some sort
• filename/filename*

RFC 6266 had no such requirement where the type must be attachment.

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3716

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] I have read the CONTRIBUTING doc
• [x] I have checked that unit tests pass locally with my changes
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] I have added necessary documentation (if appropriate)

Further comments

COMS didn't even really use the disposition type in the first place, but it still needs the Content-Disposition header because that's where it gets the filename.

[github-actions[bot]]

Coverage Report

Totals
Statements:	61.06% ( 3045 / 4987 )
Methods:	50.99% ( 335 / 657 )
Lines:	68.14% ( 1831 / 2687 )
Branches:	53.5% ( 879 / 1643 )

[codeclimate[bot]]

Code Climate has analyzed commit 82dfdc14 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (0.0% change).

View more on Code Climate.