Wip 0.0.8 - Githubissues

bcgov / common-web-utils

Common Front End JS utils and libraries

Apache License 2.0

1 stars 0 forks source link

Wip 0.0.8 #16

Closed patricksimonian closed 5 years ago

patricksimonian commented 5 years ago

improved docs
added .isA static method to TypeCheck
added units tests for TypeCheck
builds are unminified to allow for better debugging
add helper method to ImplicitAuthManager to return a bearer header
add kc_idp_hint flag in option
update documentation

jleach commented 5 years ago

I think that, in general, starting numbering with 0.1.0 is good practices. Usually the last digit is meant for minor releases. Right now, every change you make looks like a bug fix or tweak. By using 0.1.0 you can do bit release and small.

https://semver.org

patricksimonian commented 5 years ago

Great point, i'll make those changes including the versioning change and stick with semver. I'll look to get that kc_idp_hint flag in the code for this release as well. Thanks for reviewing

patricksimonian commented 5 years ago

after doing some research there is nothing saying in the key cloak docs that kc_idp_hint will work with implicit authorization. It only mentions authorization flow. I'm going to test that out before i make any changes. The one concern i have is that this flag is strictly tied to key cloak, it begs for the implicit auth manager to take in a plugin that has configurations for how urls are built so that it's not strictly tied to being an auth manager of key cloak apps.. something to think about