bcgov / common-web-utils

Common Front End JS utils and libraries
Apache License 2.0
1 stars 0 forks source link

Parse roles from JWT payload #19

Closed jleach closed 5 years ago

jleach commented 5 years ago

Some applications need to make sure only specific people can preform tasks rather than any authenticated user. This is done by assigning the user roles. This feature adds the ability for the ImplicitAuthManager to parse roles from the JWT.

jleach commented 5 years ago

@patricksimonian I created my tests outside of yours because they're a bit different. I wonder if we can adapt yours to use fixtures so there is code to write within each test. LMK what you think of the way I did it.

patricksimonian commented 5 years ago

@patricksimonian I created my tests outside of yours because they're a bit different. I wonder if we can adapt yours to use fixtures so there is less code to write within each test. LMK what you think of the way I did it.

Yeah I like it. I'll raise that as an issue

jleach commented 5 years ago

I'll do this now.