BugFix: Fix Detailed Critter SQL - Githubissues

bcgov / critterbase-api

0 stars 0 forks source link

BugFix: Fix Detailed Critter SQL #60

Closed NickPhura closed 2 months ago

NickPhura commented 2 months ago

Update the SQL when fetching detailed critters by ID.

Fixes:

Was using 'join' when 'left join' was needed
Was not accounting for the case where the critter has no mortality and/or no collection units, and as a result was returning arrays of objects with null values.

Issue became relevant when I was testing this SIMS PR (https://github.com/bcgov/biohubbc/pull/1317/commits/cb01269f7427eaee63f1e7bb4bf0e8125338b20a) which was trying to fetch detailed critters and getting no response.