CTHUB - GER allow blank/missing values in certain fields

[katerinkus]

Describe the task The following columns should allow blank values:

• Max Incentive Amount Requested
• Rebate adjustment (discount)
• Total Purchase Price (pre-tax)
• Postal code
• Phone Number
• Email
• VIN Number
• Class
• Notes

Purpose Rows that have missing values in the fields listed above, should still get uploaded.

Acceptance Criteria

• [ ] Row with missing values in the list above, gets uploaded regardless of the missing values.
• [ ] User gets a message with the index of rows that did not get uploaded because of missing values in the columns not listed above. For instance, if the Applicant Name is missing in row 100, the user should know that this happened.

Note Some of the blank values are showing up at temp_null in Metabase. I've created card #346 to address this issues as it will pertain to all uploaded data sets.

[katerinkus]

Not able to upload the file for now due to "There was an issue uploading the file" to test this card so I will try again once the issue is fixed.

[katerinkus]

@JulianForeman When I had empty values in Phone Number and Email, I got the following error:

• Warning Name: Possible Errors in Email Addresses Expected value: Verify email addresses are valid

• Warning Name: Phone Number Appears Incorrect Expected value: Ensure phone numbers match the Canadian format (XXX-XXX-XXXX)

These warnings should only apply to values that are not blank. In this case no warning should have come up for blank cells in Phone Number and Email fields since these fields are allowed to have blank values. I think it may have to do with the order in which the checks are being done. Otherwise, I had no issues!

You can replicate this issue with the test_file_missing_allowed file in GER_SUVI > test_files

[katerinkus]

I created a new ticket to address the issue above. Otherwise, the upload works as expected 👍