bcgov / cthub

Apache License 2.0
2 stars 5 forks source link

CTHUB - GER: remove incorrect warnings #384

Closed katerinkus closed 1 month ago

katerinkus commented 3 months ago

Describe the task

Remove incorrect Phone Number and Email warnings in GER dataset. When Phone Number and Email have empty values, CTHub produces the following error:

    Warning Name: Possible Errors in Email Addresses
    Expected value: Verify email addresses are valid
    Warning Name: Phone Number Appears Incorrect
    Expected value: Ensure phone numbers match the Canadian format (XXX-XXX-XXXX)

These warnings should only apply to values that are not blank. In this case no warning should have come up for blank cells in Phone Number and Email fields since these fields are allowed to have blank values. This issue may arise from the order in which the checks are being done.

This issue can be replicated using the test_file_missing_allowed file on Teams ( GER_SUVI > test_files).

Purpose Ensure that incorrect warnings do not come up for users in Phone Number and Email columns.

Acceptance Criteria

katerinkus commented 1 month ago

It all works as intended! 👍 I also noticed a UX issue. Warnings and errors remain from the first attempt. I will follow up on that with a ticket.