search

bcgov / designatedlands

Python script to combine conservation related spatial data from many sources to create a single 'Designated Lands' layer for British Columbia
Apache License 2.0
9 stars 4 forks source link

_overlaps layer doesn't have the `category` field populated #53

Closed ateucher closed 6 years ago

ateucher commented 6 years ago

I think tidy_designations() isn't working properly on the _overlaps layer, as the national park name isn't cleaned either. Possibly to do with the b prefix used in the 'preliminary output layer' but c prefix in 'preliminary overlaps layer`

ateucher commented 6 years ago

@smnorris I made an attempt here. It works, but this bit checking for 'overlaps' in the string to set the prefix might be a bit hacky. https://github.com/bcgov/designatedlands/blob/85fb0f68ba385d8dd9afcfc26b402b92601d7788/designatedlands/main.py#L69-L78

smnorris commented 6 years ago

Looks like it works fine. To clean it up more we could probably just strip the 'b' and 'c' prefixes from the designation values in those two tables, they aren't needed.