bcgov / designatedlands

Python script to combine conservation related spatial data from many sources to create a single 'Designated Lands' layer for British Columbia
Apache License 2.0
9 stars 4 forks source link

Bump urllib3 from 1.24.1 to 1.24.2 #63

Closed dependabot[bot] closed 3 years ago

dependabot[bot] commented 4 years ago

Bumps urllib3 from 1.24.1 to 1.24.2.

Changelog *Sourced from [urllib3's changelog](https://github.com/urllib3/urllib3/blob/master/CHANGES.rst).* > 1.24.2 (2019-04-17) > ------------------- > > * Don't load system certificates by default when any other ``ca_certs``, ``ca_certs_dir`` or > ``ssl_context`` parameters are specified. > > * Remove Authorization header regardless of case when redirecting to cross-site. (Issue [#1510](https://github-redirect.dependabot.com/urllib3/urllib3/issues/1510)) > > * Add support for IPv6 addresses in subjectAltName section of certificates. (Issue [#1269](https://github-redirect.dependabot.com/urllib3/urllib3/issues/1269))
Commits - [`1efadf4`](https://github.com/urllib3/urllib3/commit/1efadf43dc63317cd9eaa3e0fdb9e05ab07254b1) Release 1.24.2 ([#1564](https://github-redirect.dependabot.com/urllib3/urllib3/issues/1564)) - See full diff in [compare view](https://github.com/urllib3/urllib3/compare/1.24.1...1.24.2)


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/bcgov/designatedlands/network/alerts).
ateucher commented 4 years ago

@smnorris do you have any thoughts on whether this will cause problems?

smnorris commented 4 years ago

Seems unlikely. Might be worth testing the load command with the update.

ateucher commented 4 years ago

Ok, good idea - will do. Thanks!

smnorris commented 4 years ago

To be honest, it is not clear to me at this point if the Pipfile.lock is worth including and maintaining.

ateucher commented 4 years ago

Yeah I wondered about that myself...

ateucher commented 4 years ago

This is worth a read: https://medium.com/onzo-tech/a-tool-all-python-developers-should-be-using-5d547bfb45b7

smnorris commented 4 years ago

I like all the arguments in there but until pipenv install fiona works on windows (which should actually be soonish, I believe) I'll stick with conda for most projects.

edit - it might already work? I haven't tried in quite a while

ateucher commented 4 years ago

Hmmmm, that would be exciting! @boshek, know anyone with a windows machine that would be willing to try that? 😉

dependabot[bot] commented 3 years ago

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

ateucher commented 3 years ago

Unneccessary with #67 (urllib3 no longer specified in requirements)

dependabot[bot] commented 3 years ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.