search

bcgov / designatedlands

Python script to combine conservation related spatial data from many sources to create a single 'Designated Lands' layer for British Columbia
Apache License 2.0
9 stars 4 forks source link

simplify lostgis function inclusion #66

Closed smnorris closed 3 years ago

smnorris commented 4 years ago

There are just three functions required.

Simply include the functions in this repository rather than installing via pgxn or the windows installation script.

ateucher commented 4 years ago

Sounds good to me - as long as the lostgis licence is compatible with Apache 2.

ateucher commented 4 years ago

Looks like lostgis is BSD 3-clause, which is not copyleft so should be fine to include.

smnorris commented 4 years ago

Yes, adding those should probably have been a separate commit 🤪

ateucher commented 4 years ago

No worries.

Do you think we could include the lostgis functinos in a subfolder (sql/lostgis/)? Then put a copy of the BSD 3-Clause LICENSE file in that folder? Also in the license section in the main README.md state that those files are included from lostgis and distributed under the BSD 3-Clause license. I don't think there are hard and fast rules for how to properly include and license 3rd-party code, but I like to be as clear as possible...

smnorris commented 4 years ago

Good idea, will do.