search

bcgov / digital-gov

CSI Labs Applications and Web Presence
https://digital.pathfinder.gov.bc.ca
Other
3 stars 0 forks source link

Feat/homepage #14

Closed patricksimonian closed 5 years ago

patricksimonian commented 5 years ago

Summary

Add homepage + content

Fixes #11

repo-mountie[bot] commented 5 years ago

@patricksimonian When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 300 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs.

Here are a few thoughtful articles on what a good PR should look like:

The Anatomy of a Perfect Pull Request

Optimal Pull Request Size

Best Practices for Code Review

Pro Tip