bcgov / digital-journeys

PSA Forms System
https://bcgov.github.io/digital-journeys/
Apache License 2.0
8 stars 7 forks source link

Cold/Flu: Delete Clinic Registration Front End #1067

Closed ca-liu closed 1 year ago

ca-liu commented 1 year ago

User Story As a registrant, if I need to make changes to my clinic registration, I would need to delete the registration and create a new one.

Tasks

Acceptance Criteria

Reference to ticket #1025

iman-jamali-fw commented 1 year ago

@Stella-Archer @fazil-ey

Could you please review and confirm the UI changes in this ticket and also clarify how this new delete submitted form functionality is going to be for the existing forms (SL Review, Mat/Pat)? Thank you

Stella-Archer commented 1 year ago

@Caleb @iman @bhumin-fw just to be super clear on this ask; After a form is submitted, But NOT before it's sent to the ODS, (so while the while registration period is still open) end users (registrants) need to be able to delete their submission and start an new one? I'm wondering why they wouldn't just edit their old submission?

Stella-Archer commented 1 year ago

just applyng this to cold and flu

iman-jamali-fw commented 1 year ago

@mikeshi-bcgov

Can you please confirm if a registration by application_id 8716 is properly removed from the warehouse?

mikeshi-bcgov commented 1 year ago

@iman-jamali-fw Just fixed a bug due to field renaming, could you test again?

mikeshi-bcgov commented 1 year ago

@iman-jamali-fw I see 8718 and 8719 are marked as deleted

iman-jamali-fw commented 1 year ago

@ mikeshi-bcgov Great, thanks Mike. Can you confirm another one with id of application_id of 1839? I just deleted it from TEST environment using UI. Thanks

iman-jamali-fw commented 1 year ago

@Stella-Archer @ca-liu This is ready for testing on the TEST environment. As a regular user, you can submit a cold/flu submission and then you'll be able to delete it under "Submitted forms" tab

ca-liu commented 1 year ago

Thanks @iman-jamali-fw :)

I'm not seeing the delete button in the Submitted Forms tab, can I please double check the test url? image.png

https://digital-journeys-test.apps.silver.devops.gov.bc.ca/application

iman-jamali-fw commented 1 year ago

@ca-liu

Could be because of the cache. Can you please open it on an incognito page to make sure seeing the latest version of the website? I can see the delete on test: Screenshot 2023-05-01 at 12.10.01 PM.png

mikeshi-bcgov commented 1 year ago

@iman-jamali-fw confirm 1839 was flagged deleted as well.

ayushdamani commented 1 year ago

Tested and confirmed:

Screenshot 2023-05-01 143759.png

ayushdamani commented 1 year ago

Working in the Dev environment as well. Screenshot 2023-05-01 144445.png

Stella-Archer commented 1 year ago

yes! this worked perfectly image.png PO approved & Closing tix

Stella-Archer commented 1 year ago

I've checked in with Heather and have her approval to close