bcgov / digital-journeys

PSA Forms System
https://bcgov.github.io/digital-journeys/
Apache License 2.0
8 stars 7 forks source link

Cold/Flu Personal phone number are prepopulating primary contact field #1152

Closed Stella-Archer closed 1 year ago

Stella-Archer commented 1 year ago

User Story A short, simple description of a feature or issue told from the perspective of the user. “As a user registering a clinic I want to have my WORK/UC telephone number prepopulate so I can get have the contractor call me at WORK to book my worksite clinic. I do NOT want to share my personals information/phone number with an outside contractor.”

Tasks Currently the primary contact phone number is pulling users personal phone number image.png please check and confirm the source we are getting this number from and change to 'office Number'

Acceptance Criteria Users personal numbers do not appear on the cold and flu form

Stella-Archer commented 1 year ago

@mikeshi-bcgov @T854236 when I look at the response that we are getting from the ODS API.I see the Office Phone has no value or"" why is that? Why would the office number not be available? could we change this? we can't expose employees personal phone numbers to a contractor that would be a privacy breach. image.png

Stella-Archer commented 1 year ago

Could we point at "office_phone": "" so we're not exposing peoples personal information?

Currently the Primary phone number is not editable for regular user. It is editable for admin user only.

I'll check in with Heather to see if we can change that  to make phone number editable for primary contact.

The field is mandatory so we can label it "work phone number" and then they'd be forced to enter it manually

MeghanStothers commented 1 year ago

We will make the field editable and add a validation message to make sure people add their work numbers.

T854236 commented 1 year ago

@Stella-Archer office_phone is pulling from a table in PS where it is manually populated by the employee.

bhumin-fw commented 1 year ago

@Stella-Archer I have changed the below points. and changes are up and running on DEV and TEST.

MeghanStothers commented 1 year ago

Tested in test and report: 1) "work phone number field has been enabled to edit 2) label/title changed to to "Work phone number". Apply the same on both primary and secondary contact. 3) validation is working for this field as expected

MeghanStothers commented 1 year ago

Will need Patrick or Mike to see if the field is properly mapping to ODS

T854236 commented 1 year ago

@MeghanStothers in ODS it is just called phone and we do see a series of tests with last one at 2023-05-25 16:10:13.

bhumin-fw commented 1 year ago

@T854236 right, we are calling an API to pull employee's data. In Stella's first comment you can see that "phone" field contain Stella's private number and not work number. We need to fetch work phone some how. What are the option here to fetch it?

T854236 commented 1 year ago

@bhumin-fw

Sorry for clarity, employee demographic endpoint has both the personal and office phone number as per the screenshot provided by Stella.

The phone number and test confirmation I was referring to is with the submission and was confirming that a record was created which is exposed with the influenza_contacts endpoint.

bhumin-fw commented 1 year ago

@T854236 thank you for detail :)

Stella-Archer commented 1 year ago

The phone number field is blank and forces user to enter their work Number image.png

Stella-Archer commented 1 year ago

we will continue to explore long term solutions to WORK phone number this is captured in tix #1157 PO Approved and closing this