bcgov / digital-journeys

PSA Forms System
https://bcgov.github.io/digital-journeys/
Apache License 2.0
8 stars 7 forks source link

Mat/Pat - CRM ticket - Thread #1190

Closed fazil-ey closed 1 year ago

fazil-ey commented 1 year ago

Split from #1100 The scope of this ticket is to format the the data being sent in the thread

AC

Fields that should be in the thread -

Sample Click to enlarge

Stella-Archer commented 1 year ago

@iman-jamali-fw could you let us know where this ticket is at and if you have and estimate? thx

iman-jamali-fw commented 1 year ago

@Stella-Archer There should be no barrier to starting working on this ticket. I estimated it as 3, @bhumin-fw feel free to adjust it if needed.

bhumin-fw commented 1 year ago

@fazil-ey We need to identify fields that we want to display in thread. Please check attached image in the ticket for reference. Let me know if you have any query here.

fazil-ey commented 1 year ago

@bhumin-fw it shoudl be all fields we show in review section

bhumin-fw commented 1 year ago

Ticket is ready to test on DEV & TEST. Can be test with #1124 as well.

Stella-Archer commented 1 year ago

Maternity leave

Private Zenhub Image

Stella-Archer commented 1 year ago

@fazil-ey could you check to see if this is what I should be seeing in the CRM tix? I'm not sure about:

bhumin-fw commented 1 year ago

@fazil-ey @Stella-Archer Right now, we have covered only one page - "Review". If fields/details are on the review page then those will be there on Thread as well.

Change applied till today's morning. If any change is made on the review page section later, that needs to be updated on Thread as well.

Please let me know field/information which is not there on the review page but we want to display on CRM Thread.

fazil-ey commented 1 year ago

@bhumin-fw @Stella-Archer based on the screenshot, i think the fields you mentioned are missing

i am not sure if the form submitted had partner info. We should also test the scenario of only parental leave.

fazil-ey commented 1 year ago

Test done Aug 23 - We are not getting CRM emails and submissions are not getting validated (status did not change to validated in submitted forms tab) . Submission done my Fazil with Stella and Ayush as supervisors, submissions done by Stella with herself as supervisor.

@iman-jamali-fw @bhumin-fw

iman-jamali-fw commented 1 year ago

@fazil-ey We deployed a fix to DEV and TEST that handles an edge case allowing employees (contractors with no employeesIds) to have CRM tickets. Please try again, it should be working again.

fazil-ey commented 1 year ago

@iman-jamali-fw Test Aug 24 - got the emails! will test different scenarios and see if we are getting all fields in the CRM now

fazil-ey commented 1 year ago

Hey @bhumin-fw - the thread looks good. receiving emails However there are some missing fields

For only parental leave

bhumin-fw commented 1 year ago

@fazil-ey Let me add all missing details for thread here. I'll refer your last comment to update thread information. Let me know if anything else that needs to consider in thread details.

ayushdamani commented 1 year ago

Acceptance criteria met: Private Zenhub Image

Private Zenhub Image

fazil-ey commented 1 year ago

@bhumin-fw - mostly good. Minor changes are needed

  1. This field is a duplicate now, since we have the option Leave Allowance in both parental and maternity leave DO YOU WANT TO RECEIVE TOP-UP ALLOWANCE? Top Up Allowance: I Want To Receive My Top Up Allowance During My Leave After Acceptance From Ei

  2. There is a missing space in "EmployeeNumber"

  3. "No of weeks for standard leave" - Change to Number instead of No

Added a UX improvement in #1308 that does not need to be done right now

bhumin-fw commented 1 year ago

@fazil-ey @ayushdamani Fix all 3 points from the recent comment.

ayushdamani commented 1 year ago

Tried to test this today:

  1. Submitted a Mat/Pat form with myself as the supervisor.
  2. Still could not validate my form submission.

Next step: I will request Meghan/Stella to submit a form with me as a supervisor to test this ticket.

ayushdamani commented 1 year ago

Tested and confirmed updated ✅

  1. Meghan submitted a form with me as a supervisor
  2. I validated the form
  3. CRM ticket was generated
  4. Checked the details against Fazil's comment

Private Zenhub Image

Thank you, @bhumin-fw

fazil-ey commented 1 year ago

Additional comments addressed. Closing ticket.