bcgov / digital-journeys

PSA Forms System
https://bcgov.github.io/digital-journeys/
Apache License 2.0
8 stars 7 forks source link

COI: Building front-end (Employee Disclosure Statement) #1699

Closed ayushdamani closed 6 months ago

ayushdamani commented 7 months ago

Build the Employee Disclosure Statement tab

Acceptance Criteria

Design

Link to miro - https://miro.com/app/board/uXjVKbE3n_8=/?moveToWidget=3458764585134827511&cot=14

jerry-ey commented 6 months ago

Please test

fazil-ey commented 6 months ago
  1. Question 5 should be mandatory and Question 6 if it shows should be mandatory https://bcgov.sharepoint.com/:v:/r/teams/03991/Shared%20Documents/Conflict%20of%20Interest/Test%20recordings%20and%20screenshots/Screen%20Recording%202024-04-22%20at%208.03.56%20PM.mov?csf=1&web=1&e=zV98RM

  2. Seeing this unauthorized message when uploading files

    image.png
  3. Can we remove the file name and size box

    image.png
  4. Change the supported types message to

Supported file types: .pdf, .png, .jpg/jpeg, .docx, .eml, .msg

  1. Change the error message to

Unsupported file type. File must be .pdf, .png, .jpg/jpeg, .docx, .eml, .msg

Screenshot 2024-04-22 at 7.58.32 PM.png
fazil-ey commented 6 months ago

file upload needs to be handled in #1720

MikePSA commented 6 months ago
  1. "Please provide the following" is missing from the top of the Employee Disclosure Statement tab, according to the design on COI miro. (Ignore if doesn't matter)

    image.png
  2. Unauthorized message still shows for both questions 4 & 6 when uploading files

    image.png
  3. If you try to proceed without answering question 5, the validation error repeats the same question. Should be changed.

    image.png

Use - "This field is required"

  1. If you try to proceed without answering question 6, the validation error repeats supported file types. However, in this example I have not attached anything. Validation error message is not necessarily correct in this scenario. image.png

Use "Third Party Authorization form is required"

jerry-ey commented 6 months ago

@MikePSA , For 2. and all attachment related, please refer to other ticket as mentioned above in the comment.

CleanShot 2024-04-24 at 14.50.12@2x.png
jerry-ey commented 6 months ago

please test again.

jerry-ey commented 6 months ago

Note to me: To fix the number 4 item. Check the mat/par parental leave for example. can do error message based on different condition.

jerry-ey commented 6 months ago

@fazil-ey Based on source code of Formio, we are not allowed to change the following error message for file upload component.

But only can change the "required" error message.

CleanShot 2024-04-29 at 10.06.25@2x.png
fazil-ey commented 6 months ago

The error message is correct now when no file is attached