bcgov / digital-journeys

PSA Forms System
https://bcgov.github.io/digital-journeys/
Apache License 2.0
8 stars 7 forks source link

[Telework]: Supervisor ADM approval is n NOT showing up in the PDF #1898

Closed Stella-Archer closed 1 month ago

Stella-Archer commented 1 month ago

User Story “As a telework requestor I want to see my supervisor/ADM sign off/approval of my request in the PDF soi t is a valid and approved evidence.”

Tasks In PROD and TEST check PDF after approval for approval of PDF check when this started in PROD, inform people who haven't go the correct PDF to do so when issue is fixed

Acceptance Criteria The checklist the product owner uses to decide whether a story is done. Objective and discrete answers (such as a yes/no) that can be tested.

bhumin-fw commented 1 month ago

Changes have been deployed to the TEST environment. Please review the entire form at submission time, edit the form, and review the form for approval and denial.

Stella-Archer commented 1 month ago

Thx @bhumin I see the section in the submitted as well as the emails sent to supervisor @ayushdamani could you check you see the approvals in your employee version (both submitted tab and email sent)

image.png image.png
fazil-ey commented 1 month ago

I can see the manager approval in test pdf after approval.

Stella-Archer commented 1 month ago

@fazil-ey is that is as an employee?

Stella-Archer commented 1 month ago

@bhumin this look perfect in test - good to move fix to PROD

Stella-Archer commented 1 month ago

In PROD ready for TEST now

Stella-Archer commented 1 month ago

this is working in Prod now many thanks @bhumin-fw a new issue was discovered with validation we will write up a new tix for that closing this