DM-1119 Ensure framework.component.cmd.makeDebouncedDispatch is working correctly

bcgov / digital_marketplace

The intent of this development is to build a product that will support digital procurement needs for the BC Government including services such as, but not limited to, Sprint With Us, Code With Us, The Procurement Concierge.

Apache License 2.0

13 stars 17 forks source link

DM-1119 Ensure framework.component.cmd.makeDebouncedDispatch is working correctly #368

Closed dhruvio closed 1 year ago

dhruvio commented 1 year ago

This PR closes issue: DM-1119

Includes tests? Y Updated docs? N

Proposed changes:

Refactor the makeDebouncedDispatch function to ensure it works as intended.
Write unit tests for makeDebouncedDispatch.
Add the sinon and @types/sinon development dependencies.

bdolor commented 1 year ago

@dhruvio would you be willing to take a look at this soon?

dhruvio commented 1 year ago

@bdolor Can I do the docs in a separate PR? I have limited time each week, and don't want to block the fix from going to production.

bdolor commented 1 year ago

@bdolor Can I do the docs in a separate PR? I have limited time each week, and don't want to block the fix from going to production.

Separating documentation from the work risks not getting prioritized and given the history, preference is to advocate for it to be part of a definition of done going forward.