Feat/owner transfer - Githubissues

bcgov / digital_marketplace

The intent of this development is to build a product that will support digital procurement needs for the BC Government including services such as, but not limited to, Sprint With Us, Code With Us, The Procurement Concierge.

Apache License 2.0

13 stars 17 forks source link

Feat/owner transfer #475

Closed IanFonzie closed 5 months ago

IanFonzie commented 5 months ago

This PR closes issue: [DMM-423]

Includes tests? [N] Updated docs? [N]

Proposed changes:

Change owners by reassigning member roles in a transaction
"changeOwner" update type for affiliation resource
Change Owner button added to front-end for Marketplace Admins

Additional notes:

IanFonzie commented 5 months ago

@bdolor Can you discuss with Hugo/Jason/Inderdeep if we want to allow ownership transfer to pending members? if not we may need to adjust the following:

https://github.com/bcgov/digital_marketplace/pull/475/files#diff-84fd8b724a8eef4cf928e69425ac8f415a6c6baab6a4507097635c8471649dfeR143-R148 (filter pending members on frontend)
https://github.com/bcgov/digital_marketplace/pull/475/files#diff-5266813a76aa900f5c509021b09725bc3925bd473e7b45004dfec9b6899740bbR413 (backend validation)
https://github.com/bcgov/digital_marketplace/pull/475/files#diff-84fd8b724a8eef4cf928e69425ac8f415a6c6baab6a4507097635c8471649dfeR993-R995 (Won't be necessary anymore)

There might be more to it but that's all I can think of off the top of my head

sonarcloud[bot] commented 5 months ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud