bcgov / dts-vc-issuer-service

Digital Trust Verifiable Credential Issuer Service
Apache License 2.0
0 stars 11 forks source link

Features/immunization api #24

Closed bradhead closed 3 years ago

bradhead commented 3 years ago

Working endpoints with Schitt's Creek characters and real vaccine data, with realish locations and realistic immunization records. Just missing Dockerfile...

mtpultz commented 3 years ago

Thanks @esune, I actually spent an hour (or so) this morning trying to figure out why the immunization API wasn't standing up in Docker when I pulled this PR over a local branch, and eventually found that the folder had changed. It would be great if we could communicate structural changes in the PR description, or be aware of changes outside our PRs that it might affect.

I'm assuming the expectation is that I would hardcode patient IDs into the frontend? Both these endpoints require either a query or URI param, which I have neither. @bradhead should we consider adding a patient lookup that I can use to "authenticate" a user and pass a patient ID to the "authenticated" part of the application?

Minor points:

@itchison @AnaisHebert

Otherwise, LGTM