search

bcgov / dts-vc-issuer-service

Digital Trust Verifiable Credential Issuer Service
Apache License 2.0
0 stars 11 forks source link

Allow overriding of service ports as needed #69

Closed esune closed 3 years ago

esune commented 3 years ago

Resolves #65

swcurran commented 3 years ago

Need to add to the readme or perhaps better, the manage script the names (and defaults) of all of the ports.

I'm torn on the length of all the port names -- they are pretty long for interactive use. Putting it in the manage script at least makes it easy to copy/paste the values.

esune commented 3 years ago

Need to add to the readme or perhaps better, the manage script the names (and defaults) of all of the ports.

I'm torn on the length of all the port names -- they are pretty long for interactive use. Putting it in the manage script at least makes it easy to copy/paste the values.

Readme added, with detailed list of ports and explanation on how to override them. The french version of the readme needs updating accordingly, I could give it a stab using Google translate and some guesswork based on Spanish/Italian grammar, but I think one of the folks from Quebec would do a much better job in a fraction of the time 😉

I am honestly not too concerned about the port names: based on the experience so far (with the other projects we created/support), it seems like the need to change the defaults is almost a one-off and most people are likely NOT going to need to change anything.

swcurran commented 3 years ago

@esune -- could you update to fix the conflict? It's a trivial change fortunately. Thanks!

esune commented 3 years ago

@swcurran it should be good to go now.