EE-1199: Remove minio

[BcGovNeal]

One thing, since the MINIO_* values are mounted from the nr-object-store-credential secret, you could just update the deploy config to use that instead of using params.

- name: MINIO_HOST
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: endpoint_url
- name: MINIO_ACCESS_KEY
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: user_account
- name: MINIO_SECRET_KEY
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: password
- name: MINIO_BUCKET_NAME
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: bucket_name

[marklise]

MINIO_HOST

That would require re-creating all the nr-object-store-credential secrets in all the environments just to add in something that isn't NR-object store specific. I would argue against this as eventually MINIO should be stripped entirely.

[BcGovNeal]

MINIO_HOST

That would require re-creating all the nr-object-store-credential secrets in all the environments just to add in something that isn't NR-object store specific. I would argue against this as eventually MINIO should be stripped entirely.

You are correct that the nr-object-store-credential secret would be a pre-requisite, however we already have those secrets in all the environments test and prod, and that's how the API is being deployed currently. When we strip away MINIO we should still be using the same secret.

[marklise]

One thing, since the MINIO_* values are mounted from the nr-object-store-credential secret, you could just update the deploy config to use that instead of using params.

- name: MINIO_HOST
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: endpoint_url
- name: MINIO_ACCESS_KEY
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: user_account
- name: MINIO_SECRET_KEY
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: password
- name: MINIO_BUCKET_NAME
  valueFrom:
    secretKeyRef:
      name: nr-object-store-credential
      key: bucket_name

Fixed in a8cf453

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication