bcgov / ecc-ofm

Ministry of Education and Child Care - Operating Funding Model app
Apache License 2.0
0 stars 0 forks source link

Ofmcc 2037 funding agreement view #192

Closed jgstorey closed 2 months ago

jgstorey commented 2 months ago

NOTE 1) Date validation when using 'Custom' date filter option is still subject to change and there is a console error. Need to confirm expected validation behaviors with Danna before i go further, this will be done before PR approved. Didn't want to hold up initial 1st pass of code QA. 2) Things i could spent more time on but need to get sense of value in doing so: a) Added component AppButtonRadioGroup.vue for radio button options. This is very similar but more generic than AppYesNoInput component. We could remove and refactor with AppButtonRadioGroup though will require some tweaks. b) Could make content of v-window-item tab value 'agreements' a component.