bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

UI - Fix Text Titles for Amendment types in Registration Table #10805

Open tlebedovich opened 2 years ago

tlebedovich commented 2 years ago

Scott noticed that there are unexpected Registration Type titles for the different types of amendments appearing in the My Registration tables.

For example, "Partial Discharge" should instead say "Amendment – Collateral Deleted"

Example DEV Screenshot (refer to spreadsheet for all the different types): Screen Shot 2022-01-24 at 11.26.28 AM.png

tlebedovich commented 2 years ago

@forgeuxGH5 - fyi, finally made this bug ticket

mstanton1 commented 2 years ago

Adding another scenario identified by a client today:

When amending a debtor (e.g. changing last name), currently the output lists the legacy title "Debtor Transfer" instead of the updated title "Debtor(s) Amended"

image.png

forgeuxGH5 commented 2 years ago

@mstanton1 have we communicated this change to users yet, or checked their preference? Having had a few brief conversations with some users it seems we will get questions / comments about this.

mstanton1 commented 2 years ago

@forgeuxGH5 we have not yet communicated to users. Let's meet briefly today to address the questions/comments we may get and how we can best get ahead of that.

PatrickAHeath commented 2 years ago

@forgeuxGH5 Comment from Chelsea via Discourse:
We have a inquiry about badges - if in an Amendment a debtor name and address was changed, how will the badges show the verification statement?

We had an issue in the past where the name of a debtor was amended to include periods, like “ltd.” - and a space as added in the postal code, from T9E0A9 to T9E 0A9. The Debtor showed as Added and Deleted, when one might have expected a “Name Changed - formerly ___” and “Address Changed”. Unsure if the release of this ticket amends this operation or if this is still being reviewed.

forgeuxGH5 commented 2 years ago

@PatrickAHeath Hmmm... yeah that's one a bit of a combination of action (amending the Debtor) and the Badges and the Title.

Right now it's breaking the Amend action into a Delete and Add and getting recorded as a Debtor Transfer.

It should look like this: UI Button / Action: Amend (Debtor) UI Badge: Amended UI Column Label / PDF Verification Statement Title: Amendment - Debtors Amended PDF Verification Statement Badges: Name Changed (formerly xx), Address Changed, Birthday Changed.

Might as well include checking/spec'ing this here - will increase scope though

forgeuxGH5 commented 2 years ago

@mstanton1 FYI - I also noticed a Birth Date change was registered as an Address Change on the verification statement for a legacy registration - so we should check all the badging.

I'll add that here.