search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Registry UI: What's New panel is hidden on some screen widths, blocks everything else #11065

Closed severinbeauvais closed 2 years ago

severinbeauvais commented 2 years ago

On https://yfthig-dev.web.app/, at screen widths below 1264px (which includes most or all mobile), the What's New panel is hidden and blocks all other actions. (User needs to refresh the page to hide overlay and be able to use the page.)

I noticed dynamic classes v-navigation-drawer--is-mobile and v-navigation-drawer--close are applied below that breakpoint (the latter hides the panel). I noticed that this happens on some pages only. (It does not happen on https://dev.bcregistry.ca/business/auth/.) This suggests a class is missing from the bcregistry app.

cc: @pwei1018

severinbeauvais commented 2 years ago

@jdyck-fw @forgeuxGH5 @lmcclung

Do you think this is a P1? It's probably an easy fix but I don't have a solution yet. Maybe Patrick will know right away.

PS There will be a bcregistry release to Prod very soon. I think it would be nice to have this fix in there.

forgeuxGH5 commented 2 years ago

I'd vote lower that P1 just because it's unlikely to occur and we haven't focused on mobile (our apps aren't really designed/built for mobile) If you could quickly remove the overlay part of the implementation that would at least let people access the page.

severinbeauvais commented 2 years ago

Fixing the overlay would be the fix :)

severinbeauvais commented 2 years ago

Test Notes:

  1. go to BC Registry app (any page)
  2. ensure you are logged out
  3. click the What's New button
  4. resize your browser window to below and above 1264 px
  5. verify that the What's New panel remains displayed
  6. verify that user can close the What's New panel and then click on other page buttons/links
severinbeauvais commented 2 years ago

@forgeuxGH5 @yuisotozaki Dunno if you want to have a look at this or just bump it to RFQA.

yuisotozaki commented 2 years ago

I'm seeing the original behaviour still on PPR main page as well as redirected login page

Also, when the user clicks outside the displayed What's New box, the What's New box should go away. I.e. same as close button click.

severinbeauvais commented 2 years ago

This implementation has only been deployed to bcregistry Dev (https://yfthig-dev.web.app/) thus far.

It has not been deployed to bcregistry Prod (https://www.bcregistry.gov.bc.ca/) or Test (https://www.bcregistry.daxiom.ca/).

I don't see the issue in Auth Web Dev (https://dev.bcregistry.ca/business/auth/login?redirect=%2Fstaff%2Fdashboard%2Factive)...?

severinbeauvais commented 2 years ago

Also, when the user clicks outside the displayed What's New box, the What's New box should go away. I.e. same as close button click.

That's a good idea but it wasn't implemented that way in #9811 and THIS ticket is only to fix a style issue.

forgeuxGH5 commented 2 years ago

Looks good to me in dev - I don't see the issue in Auth either but QA can confirm that- RFQA