bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

INC0148511 - User unable to use NR in colin because they didn't enter their home jurisdiction number #11380

Closed sienna-oldaccountdontuse closed 10 months ago

sienna-oldaccountdontuse commented 2 years ago

Describe the bug in current situation After #8558 was released, this bug was introduced.

8558 only implemented the ability for clients to see the HJ number in NameX. Not sure why this change has prevented clients from using the NR. Maybe this is an unrelated issue?

From Jenn, INC0148511

Hi Team,

We just encountered an issue with this recent update in Namex, and it is preventing clients from being able to use their NR to complete the filing for some NR’s.

What’s happening is, when a user does not enter the “corporate number”, they are given the opportunity to enter the name only. When the name is entered instead of the number, the name displays in Namex on the examination page, and the NR becomes “locked” with this info. Once the name is approved, it actually blocks the filing from being completed and is unusable.

The NR we came across for this situation is NR 4328912, for the name, “WEALTHY LIFE FINANCIAL SERVICES CORP.”:

image.png

I attempted to try all the workarounds I could think of to change the NR type, etc., but no matter what we tried do, the NR could not be edited to remove or correct this information. The only way to help the client move forward on this was to create a replacement NR, to enter the correct information from the start. The replacement NR we created to assist the client is NR 4251706, and the filing was completed successfully.

Can someone please have a look into this ASAP please?

Also, I have CC’d the examiners so they are aware of what’s happening.

Thanks,

Jenn

Impact of this bug High impact, prevent clients from using their NRs, and staff can't do a workaround so they need to completely remake their NR. Lots of effort.

Chance of Occurring (high/medium/low/very low) High chance of occurring for XPRO BC NRs and we can't validate the number so we ask then to enter the name. Of all the XPRO NRs in BC - I think that is a decent amount

Steps to Reproduce

  1. Request a name, BC XPRO
  2. In the name request, enter a name (not a number) when asked for the number or name in the xpro jurisdiction
  3. Approve the NR
  4. see that you cannot edit the xpro name anywhere
  5. try to file a filing using the NR
  6. See that the filing does not work, the NR cannot be used

Expected behavior This NR should be usable in COLIN

sienna-oldaccountdontuse commented 2 years ago

Screen Shot 2022-03-03 at 8.40.06 AM.png

jdyck-fw commented 2 years ago

@ozamani9 @jinghualicgi - This is a priority1, moving it over to to-do for SRE.

eve-git commented 2 years ago

I could not reproduce the issue in DEV. @sienna-blumstengel can you reproduce the issue? Thanks

lmcclung commented 2 years ago

@lmcclung to ask home team BAs to replicate this type of NR and then try registration in COLIN.

JohnamLane commented 2 years ago

Note from Jenn:

The error that is being generated for this issue is occurring when the filing is attempted in Colin and not in the names system, so I don’t have an example to send. I’m sorry I can’t confirm the exact error message.

jdyck-fw commented 2 years ago

@sienna-blumstengel - Any updates after connecting with the home team?

sienna-oldaccountdontuse commented 2 years ago

Sounds like Patty doesn't have any more information than I do, I will reach out to her again and see if I miscommunicated

sienna-oldaccountdontuse commented 2 years ago

image010.jpg image011.jpg

Patty sent these screenshots from when issues were happening. I just looked in NameX today...:

Hi Patty, Thanks for the screenshots! I just searched NR 0859496 and NR 4251706 in NameX, it looks like they were able to use it and register successfully? Have you seen this issue occur recently?I don't see anything unusual in the console, I was hoping to see an error message. Sorry for the delay on this, thanks for your help! Sienna

lmcclung commented 2 years ago

Emailed staff with update March 28
https://app.zenhub.com/files/157936592/fd17f8f9-27c5-46c2-9b03-b0eb3d1bc866/download

jdyck-fw commented 2 years ago

Leaving this for next week.

jdyck-fw commented 2 years ago

@lmcclung - To check what email updates she has on this.

jdyck-fw commented 2 years ago

Linda will follow up

eve-git commented 2 years ago

I tested again in DEV environment:

  1. requested the name NR 0372619, Extraprovincial Limited Company, Alberta, name: EVE TEST ALBERTA
  2. approved the name
  3. registered an extraprovincial company by using the name. entered the home jurisdiction number during the filing
  4. the company was registered successfully, number: A0079108
  5. checked back the name, the name status is Request Status: Approved / Used For A0079108

Everything looks good to me.

eve-git commented 2 years ago

namex UI showed different from what in the description. I wonder if the bug has been fixed? image.png

jdyck-fw commented 2 years ago

@mdinu1961 to follow up with @lmcclung for a way to reproduce this.

eve-git commented 2 years ago

Steps to reproduce the issue in DEV:

  1. login a Visual Service Card
  2. Request a name: a. filling the request form: Extraprovincial, Limited Company, Alberta b. don't check "I don't have a corporate numbe" c. enter something, whose length is over 30 characters, in corporation number field d. click the link "Submit this Name without checking" under "Check this Name" button e. In the "Corporate Number Not found" window, input the corp name and click "Search" button" f. finish the name request
  3. Go to colin to register a extraprovincial corp by using the NR
  4. The error show up at the top banner as "An unknown error has occurred in the name reservation system. Please contact system support."
lmcclung commented 2 years ago

I opened an enhancement ticket 11716 and will get UX eyes on it for how to improve the user experience so they don’t submit the NR without checking. Might be simplest to hide the ‘submit this name without checking’ for extraprovincial name requests.

eve-git commented 2 years ago

colin log:

2022-05-18 08:18:49,639: (, anon, REGS2, dummy) ERROR[axis14.NameRequestServiceAxis14] NameRequestServiceAxis14.getStatus failed: 
org.apache.axis2.AxisFault
    at org.apache.axis2.AxisFault.makeFault(AxisFault.java:430)
    at ca.bc.gov.registries.nro.ws.client.axis14.NewNameRequestServiceStub.fromOM(NewNameRequestServiceStub.java:948)
    at ca.bc.gov.registries.nro.ws.client.axis14.NewNameRequestServiceStub.GetStatus(NewNameRequestServiceStub.java:349)
...
Caused by: java.lang.RuntimeException
    at ca.bc.gov.bcregistryservices.www.nro.services.VARCHAR_30.setVARCHAR_30(VARCHAR_30.java:63)
    at ca.bc.gov.bcregistryservices.www.nro.services.VARCHAR_30$Factory.parse(VARCHAR_30.java:417)
    at ca.bc.gov.bcregistryservices.www.nro.services.GET_STATUS_RESPONSE$Factory.parse(GET_STATUS_RESPONSE.java:987)
    at ca.bc.gov.bcregistryservices.www.nro.services.GetStatusResponse$Factory.parse(GetStatusResponse.java:394)
    at ca.bc.gov.registries.nro.ws.client.axis14.NewNameRequestServiceStub.fromOM(NewNameRequestServiceStub.java:914)
eve-git commented 2 years ago

@lmcclung I dug into the error and found out the real cause of the error. (see my second test case). I will ask Patty to take care of it if an extraprovincial company name can exceed 30 characters. Meanwhile, before 11716, do I need to fix the error in my first test case by removing the corp number value after entering a corp name? so that in colin, corp number field leave blank in the case.

eve-git commented 2 years ago

colin calls getStatus and the homeJurisNum in the response isn't correct. homeJurisNum should be null. The homeJurisNum is retrieved from request_instance table.

<GetStatusResponse>
  <errors />
  <nrNumber>NR 3254587</nrNumber>
  <findStatusCode>SUCCESS</findStatusCode>
  <nameRequestStateCode>A</nameRequestStateCode>
  <approvedName>PATTY CRACKED TO CODE TEST LTD.</approvedName>
  <expiryDate>2022-05-24</expiryDate>
  <xproJurisdiction>ALBERTA</xproJurisdiction>
  <homeJurisNum>PATTY CRACKED TO CODE TEST LTD.</homeJurisNum>
</GetStatusResponse>

if the extraprovincial name input correctly, the get status response is like below and no errors in colin:

<GetStatusResponse>
  <errors />
  <nrNumber>NR 4864398</nrNumber>
  <findStatusCode>SUCCESS</findStatusCode>
  <nameRequestStateCode>A</nameRequestStateCode>
  <approvedName>EVE TEST 11380 NAME OVER 30 2 LTD.</approvedName>
  <expiryDate>2022-07-13</expiryDate>
  <xproJurisdiction>ALBERTA</xproJurisdiction>
</GetStatusResponse>
eve-git commented 2 years ago

Work around execute the following script in namesp:

update request_instance ri
set ri.home_juris_num = null
where ri.request_id=
    (select request_id 
    from request r 
    where r.nr_num = 'NR xxxxxxx');
jinghualicgi commented 1 year ago

@lmcclung Linda, please let us know your decision who to proceed, thanks

Mihai-QuickSilverDev commented 1 year ago

@jinghualicgi Hello, we will pass the two options by the Business team in our requirements meeting tomorrow, and plan to have a final answer for you by tomorrow afternoon. @lmcclung @eve-git

jinghualicgi commented 1 year ago

@Mihai-QuickSilverDev any update regarding this ticket? Thanks

jinghualicgi commented 1 year ago

@Mihai-QuickSilverDev @lmcclung any update regarding this ticket? Thanks

jinghualicgi commented 1 year ago

Following-up with this ticket @lmcclung @Mihai-QuickSilverDev

jinghualicgi commented 1 year ago

@davemck513

jinghualicgi commented 1 year ago

Make it visible on entities board, and assign to David and Mihai for entities' input

jinghualicgi commented 1 year ago

@davemck513 @Mihai-QuickSilverDev any update regarding this ticket? Thanks

eve-git commented 10 months ago

The ticket can be closed.