search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Filings UI: replace SVG with MDI icon #11675

Open severinbeauvais opened 2 years ago

severinbeauvais commented 2 years ago

The Dissolve This Company button icon previously didn't not exist, so a SVG version was implemented.

Now, the Material Design Icons library includes this icon, so we should change over and clean up our code a bit.

image.png

Refs: https://github.com/Templarian/MaterialDesign/issues/6261 https://www.npmjs.com/package/@mdi/font/v/6.6.95

image.png

severinbeauvais commented 2 years ago

This is NOT tech debt, because we didn't know for sure whether MDI would support the new icon we needed, so the SVG version was a permanent solution... but not an ideal solution. Now the icon is available and that's better.

sienna-oldaccountdontuse commented 2 years ago

@shabeeb-aot can your team work on this when completing the dissolution filing? FYI @jyoti3286 @SateeshFW

jyoti3286 commented 2 years ago

any idea how much effort it is? @severinbeauvais CC: @lmcclung

severinbeauvais commented 2 years ago
  1. update library import version
  2. update 1 line of code
  3. delete obsolete svg file

Maybe 10 minutes of work + overhead for creating branch, committing, reviewing, etc -- this is a good candidate for doing as part of another ticket!

jyoti3286 commented 2 years ago

@severinbeauvais - Does this impact all the icons across all our applications? Just trying to understand the impact.

severinbeauvais commented 2 years ago

If no icons that we use are deprecated in the latest icon library (and I don't if so or not) then there should be zero impact.

The icons we use are easy to search for in the code, so maybe we need another step above to ensure they are not deprecated/removed from the latest icon library version.

sienna-oldaccountdontuse commented 2 years ago

Dependency and Relationships labels added. @SateeshFW @jyoti3286 please let us know if it makes sense for your team to do this work

shabeeb-aot commented 2 years ago

Some icons are missing in "@mdi/font": "^6.6.96", version. like we pdf icon which we used inside view document. So maybe we have to use pdf icon Screen Shot 2022-05-10 at 2.57.57 PM.png we have to use SVG for the pdf icon

mdidesign - Breaking Changes https://github.com/Templarian/MaterialDesign/issues/5409

After an update in local, it will be like this Screen Shot 2022-05-10 at 3.04.53 PM.png

jyoti3286 commented 2 years ago

Not required for now