bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

Fix Certificate Layout #12213

Closed lmallika86 closed 2 years ago

lmallika86 commented 2 years ago

Describe the bug in current situation The certificate layout is broken. The borders are not correctly displayed and the incorporation number is wrapped. This needs to be fixed

Link bug to the User Story

Impact of this bug Describe the impact, i.e. what the impact is, and number of users impacted.

Chance of Occurring (high/medium/low/very low)

Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?

Steps to Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Actual/ observed behavior/ results

Expected behavior A clear and concise description of what you expected to happen. Use the gherking language.

Screenshots/ Visual Reference/ Source If applicable, add screenshots to help explain your problem. You an use screengrab.

yuisotozaki commented 2 years ago

The border SVG file used clipping masks to render the corners. From looking around online, clipping masks may not be supported by some SVG standards like SVG Tiny. We're not 100% sure if the 3rd party libraries were updated on the API side that stopped supporting clipping masks.

The border SVG file's elements that used clipping masks were re-created without clipping masks and that fixed the issue.

Samples are attached here for future reference in case we run into similar problems. Original SVG with issues: REGI_Societies_Act_certificate_border.svg Updated SVG: REGI_Societies_Act_certificate_border test 6b.svg

Problematic output with the original SVG: Download Fixed output with the fixed SVG: Download