bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

MHR Search Algorithm Testing #12626

Closed mstanton1 closed 1 year ago

mstanton1 commented 1 year ago

Note: request pending to have PROD data loaded into TEST to enable more testing scenarios. If we are unable to have this data moved over we could ask to use PROD for testing. DONE

If testing in PROD we have an added dependency of having the API up in PROD, UI up in PROD.

Need RACF ID and password for DB2 in PROD.

First 22 lines provide a starting point for testing: https://docs.google.com/spreadsheets/d/1Oe50zwE0pQGT7m0VHyma302RtNlXepZEQyq5t7B8NIU/edit#gid=0

Additional tests need to cover edge cases (e.g. one with lots of results)

Note: Serial number is most complicated so should have more extensive testing.

mstanton1 commented 1 year ago

Hey team! Please add your planning poker estimate with ZenHub @cameron-freshworks @dimak1 @doug-lovett @garyfan1 @thorwolpert

mstanton1 commented 1 year ago

Hey team! Please add your planning poker estimate with ZenHub @cameron-freshworks @dimak1 @doug-lovett @garyfan1 @thorwolpert @chdivyareddy

dimak1 commented 1 year ago

Updated the spreadsheet with Performance Testing results for MHR Search (since Patrick is doing Algorithm Testing).

PatrickAHeath commented 1 year ago

Search Algorithm Testing sheet has been updated. Issues encountered:

mstanton1 commented 1 year ago

@PatrickAHeath have items identified above been sent to Doug? Given the size of this ticket I believe it included the dev fixes so we can track against what was identified to ensure the items are fixed?

PatrickAHeath commented 1 year ago

@mstanton1 Or should we create a new ticket to fix each issue?

doug-lovett commented 1 year ago

@PatrickAHeath @mstanton1 I think the second item is a performance issue and should be resolved in TEST with 12773 currently in review. The org name change and owner name change to include historical names - a missed requirement - is included in the 12773 pull request. The search number search fix is also included in the 12773 pull request.

PatrickAHeath commented 1 year ago

@doug-lovett @mstanton1 Will retest when 12773 is in TEST.

mstanton1 commented 1 year ago

@PatrickAHeath @doug-lovett thank you for the update. Once in test please confirm if any of the above items are outstanding. If so we can log a separate task (high priority - pull into sprint) and then work on that to ensure we can get search out. cc @jinghualicgi

doug-lovett commented 1 year ago

@PatrickAHeath the serial number fix for the issue you identified in 12773 this morning with 123ABC is now in TEST.

PatrickAHeath commented 1 year ago

Serial Number search now looks good.

PatrickAHeath commented 1 year ago

@doug-lovett @mstanton1 @forgeuxGH5 @tlebedovich Owner Name and Organization Name searches for MHR - I think we need to redesign the search results display for them since the status should refer to the name result. Perhaps both Name Status and Registration Status should display.

doug-lovett commented 1 year ago

@PatrickAHeath can you create a ticket for the API change and put it in the sprint backlog.

PatrickAHeath commented 1 year ago

@doug-lovett 12830 created for the API change to add Owner Status to the results.

mstanton1 commented 1 year ago

@PatrickAHeath from your earlier comment I checked off the serial number issue as resolved. The remaining three items in your comment six days ago are all part of 12773 which has been moved to TEST. Can you re-test these?

tlebedovich commented 1 year ago

@PatrickAHeath - please create a design ticket if we need to do any design work to update search results (UI and/or Output)

PatrickAHeath commented 1 year ago

@tlebedovich One clarification that's needed on the MHR search results is the difference between MHR Registration Status and MHR Owner Status. Doug has completed the change to include both in the API (12830). I can't find a design ticket for it so will create one. (12935 created)

PatrickAHeath commented 1 year ago
doug-lovett commented 1 year ago

@PatrickAHeath please retest org and owner searches missing duplicate results (not matching legacy) in TEST. Unit test org name: CRYSTAL RIVER COURT LTD. Individual name: KAREN HUNT

PatrickAHeath commented 1 year ago

@doug-lovett Individual Name search - all the entries are displaying, but status doesn't seem to be that of the owner. For Karen Hunt, expecting one active and 2 historical on 017658.

Legacy: image.png

Modernized: image.png

PatrickAHeath commented 1 year ago

Same for Organization Search (Crystal River Court Ltd.) - all results are displaying as Active.

Legacy: image.png

Modernized: image.png

doug-lovett commented 1 year ago

@PatrickAHeath The owner status display issue is a UI change, not an API change. The API change is only for the set of results. The API is already returning the owner status; the UI is not displaying it.

mstanton1 commented 1 year ago

@RFK250 this is one of the key search tickets needed for the launch. If you review the last two comments from Patrick and then comment from Doug immediately above this you will see the issue.

This additional UI work needs a task created and to be added to the sprint. If it is not added / tackled we are in a state where the results being retrieved do not match so could not be released to users. I will create a ticket, add it to the sprint, and see who can pick it up. Note: In sprint demo one of the metrics is the work added and PO's are often asked to speak to their scope changes.

RFK250 commented 1 year ago

Ticket referenced by Melissa above: #12974

@PatrickAHeath Does that ticket block you from completing this one?

PatrickAHeath commented 1 year ago

@RFK250 Yes - the outstanding issues are having the owner status display in a column marked Owner Status (I still feel the breakdown of search results by Active, Exempt, Historic should be for Registration Status), displaying all matching owners in a single registration (currently only 1 is displaying), and getting the policy decision on whether individual owners should be displayed as matches on an organization search.

RFK250 commented 1 year ago

Okay, thanks @PatrickAHeath !

RFK250 commented 1 year ago

@PatrickAHeath #12974 is done and is no longer a blocker to this ticket. Woohoo! :D

catherinecarlson commented 1 year ago

The BCOL legacy MHR/PPR combo search with liens is working correctly due to the mismatch of databases being searched.

MHR Test – has prod data only PPR Test – test data only Combo search – compares MHR prod data with PPR test data

No other outstanding search issues at this point.

mstanton1 commented 1 year ago

Moving to closed. Following the last comment @catherinecarlson completed additional testing and caught a bug where draft information was being reflected in the outputs in the modernized system. This was addressed before the SBC Prod Pilot launch. No other search output or algorithm related issues were identified.

Note: Staff also completed testing prior to the launch and the only issue found was also related to draft, and resolved promptly in the same ticket that Catherine had raised.