NameX - Restoration/Reinstatement NRs should be 1 year 56 days for Societies

[lmcclung]

We probably missed this last time when we fixed the expiry dates for other entity types.

[eve-git]

Wait for python 3 upgrade complete.

[PatrickAHeath]

@eve-git Staff are asking about this issue. Has the Python 3 Upgrade happened? Is this really part of the current sprint?

[eve-git]

Python Upgrade has been completed. @ozamani9gh will work on it.

[ozamani9gh]

I am looking at the code and i see Society's RESTORATION/REINSTATEMENT logic hitting 421 days (1 Year and 56 days).

@PatrickAHeath are you able to reach out staff and see if this is still an issue, and if it is, can they give me a couple of NRs to look at it. I need to look in DB to figure out a combination of

Entity Type and Request Action. thats how it determines expiry date of 56 days/ 1 year 56 days

[PatrickAHeath]

@ozamani9gh If the logic in PROD is set to 1 year 56 days, all that may be required is a report of those NRs that were created prior to the change in logic so staff are aware that they have to be adjusted.

[PatrickAHeath]

@lmcclung @elizabethanneespinosa @jujubenjewel @MeganFedora I'm not sure who is responsible for Societies. Are NRs still being created with 56 day expiry dates? If not, is a report of those created before the change with 56 day expiry required?

[jujubenjewel]

@PatrickAHeath I have an example of an NR submitted on Nov.28, 2022 for society restoration that only received an approval period of 56 days NR2001312. Earlier today I went into NameX and extended the NR for the client, so that it doesn't expire prior to us filing the restoration. I have another example, NR9515739 which was submitted Oct.27, 2022 and the system issued an expiry date of Dec.23, 2022. client contacted us and we were able to extend it in NameX as well.

We are also starting up society dissolution runs again in April this year, so I expect by mid-year we are going to start seeing a lot more society restoration NRs being submitted on the name request application.

Jennifer Weldon (sr. analyst from the names unit) was emailing me about this issue back on Jan. 04. She advised me at that time that the issue still persists and that we had already requested a report to try capture the NRs with incorrect expiration dates that we could update the already approved NRs. Jenn might have more information about this.

[PatrickAHeath]

@ozamani9gh When was the code change to 1 year 56 days made in PROD? Are there other society NR request actions that have expiry set to 56 days? Are we looking at the correct Request Action?

@jujubenjewel has provided NR examples in the comment above.

Would a query of all Society Restoration/Reinstatement NRs with their creation Date and Expiry Date help to determine when a change was made and what recent NRs have for expiry date? The business wants a report of these so they extend those that are about to expire.

[jujubenjewel]

Society incorporation and society name change NRs only have 56 days until expiry. Society restoration and extraprovincial non-share corporation reinstatement (xpro societies) name requests should have 1 year and 56 days until expiry

[ozamani9gh]

@PatrickAHeath @jujubenjewel thanks for the info, i will query database and figure out why they are not getting the 1 year and 56 day interval.

[ozamani9gh]

Both of these NRs have request_type_cd of RSO (restoration society).

my logic checks for that request_type_cd and if its RSO or XRSO it sets expiry_date to 421 days.... so not sure what happened with two NRs above.

select id, last_update, nr_num, request_type_cd, additional_info, expiration_date, request_action_cd, name_search from requests where nr_num IN ('NR 2001312','NR 9515739')

.

I will check the other NRS that have request type cd of RSO/XRSO and see if any of them have an expiration_date of 421 days

[PatrickAHeath]

@ozamani9gh Can you provide the business with the results of a query showing NRs that do not have the 1 year 56 day expiry window? (including the expiry date) They can then use that info to extend the Society NRs that are about to expire but should still have another year.

[ozamani9gh]

@PatrickAHeath I sent an email to Jennifer Weldon yesterday with 66 Societies that have an expiry date after January 1st, 2023. she is working on that now. I am still trying to figure out why my logic does not work. I have logic for RESTORE/REINSTATE Societies and XPRO societies to have the 1 year 56 days added to expiration date, but its not working in prod... will give you update as soon as i figure out why and its fixed in my local environment

[ozamani9gh]

I have my changes in DEV

@riyazuddinsyed hopefully you have time to test this today or tomorrow

[ozamani9gh]

@droberts27 @MKagis

Modernization part ready to go to prod. please let us know when your changes have been tested and ready for prod, we should sync our migration together

[MKagis]

@ozamani9gh We're still waiting to hear from @kialj876 about how the EXPIRATION_DATE data flows into our NAMEST database. We need that information before we can continue our work.

Point is: we have a dependency on action from modernization staff before we can continue our work.