search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Investigate updating issued_at field in transaction table to include timezone #12889

Closed argush3 closed 2 years ago

argush3 commented 2 years ago

@droberts27 had pointed out that all timestamp related fields in the LEAR db contain timezone except for the issued_at field in the transaction table.

Some investigation needs to take place into whether there will be any unintended side effects in updating the db field type and the existing data to include the timezone.

I believe this table is related to SQLAlchemy Continuum which is a versioning extension for SQLAlchemy. There may be constraints as to what is possible depending how SQLAlchemy Continuum is implemented.

Mihai-QuickSilverDev commented 2 years ago

Need to confirm whether OrgBook uses this piece of info.

argush3 commented 2 years ago

@droberts27 do you know if Orgbook actually uses the issued_at field in the transaction table in LEAR db? just trying to determine if this change really needs to be made or if it's a nice to have to maintain consistency at this point.

argush3 commented 2 years ago

@droberts27 has sent an email to Orgbook folks asking whether they are using transaction.issued_at field on July 20th. Currently, waiting for reply.

argush3 commented 2 years ago

@droberts27 since Orgbook will use filings.completion_date, are you ok with closing this ticket for now?

droberts27 commented 2 years ago

sure