Misc bug fixes/updates to SP/GP pipeline (part 2)

[argush3]

TODOs

• [x] Event.trigger_dts will be mapped to businesses.dissolution_date and businesses_version.dissolution_date. It is only used for dissolutions
• [x] parties.identifier needs leading BC (moved from #13051)
• [x] verify all ledger_text notation entries are mapping to right places in LEAR
• [x] go through filing types one more time to ensure all event/filing type scenarios are being data loaded
• [x] pacific date to UTC date conversion issue
• [ ] ~does user data need to be pushed to auth?~ will be taken care of in #13046
• [x] verify custom filer code does not require updates i.e. new filer updates may have been pushed filer since implementation of custom filer processors
• [x] update comment logic for saving staff/filing comments
• [x] corp party entries of party type "FBO" with no business_name unable to pass pipeline and custom filer validation
• [x] map corp_frozen_type_cd to LEAR db

[jdyck-fw]

Consider sharing this knowledge with someone else when the ticket comes up.

[argush3]

@davemck513 i'm out of work as all my tickets are in review so I'm pulling this ticket into the sprint to work on. Let me know if I should be working on something else. cc: @jdyck-fw

[argush3]

@droberts27 @rarmitag I have data loaded some SP/GPs in DEV so you can verify data fixes for the bug fixes and updates I have made to the pipeline.

FM0822391 - use event.trigger_dts for dissolution date

FM0620293, FM0620449 - add leading BC to parties.identifier

FM0814468, FM0385546 - add business comments mapping

FM0554193, FM0554211, FM0554212 - UTC conversion issue

FM0314690, FM0687859 - missing business name issue

FM0713982, FM0805895 - frozen firms

FM0000226 , FM0695709 - ledger text not being pulled over for registrations and dissolutions

[droberts27]

@argush3 FM0822391 - Dissolution date looks good on the output. Should the same dissolution date of December 31, 2021 be on the dashboard:

The statement of dissolution for General Partnership PANGEA PRODUCTIONS - IMPORT_TEST was successfully submitted on April 23, 2022 at 10:01 am Pacific time with dissolution date of April 23, 2022.

[droberts27]

@argush3 FM0620293 not searchable because it has 2 business rows. Appears to be sole prop with 2 owners id=499883 and id=545808. The latter has the correct BC prefix.

[argush3]

@droberts27 I removed both instances of FM0620293 and reloaded in DEV.

[droberts27]

@argush3 FM0620293 looks good!

[droberts27]

@argush3 FM0620449 looks good!

[droberts27]

@argush3 FM0814468 and FM0385546 comments look good!

[droberts27]

@argush3 FM0554193 businesses.founding_date looks wrong

[argush3]

@droberts27 founding date will be fixed in #12890 I believe. When we sort out the business start date and etc.

[droberts27]

@argush3 FM0554211, FM0554212 filings.filing_date and filings.effective_date look good

[droberts27]

@argush3 FM0314690 looks good but outputs are failing FM0687859 looks good Please reprocess FM0468147 it has 3 names.

[argush3]

@droberts27 FM0468147 is only partially processed because the pipeline doesn't support corrections yet. That is basically the last filing I need to add. Once the entities team finishes up the final implementation I'll add support for that.

[droberts27]

@argush3 FM0713982, FM0805895 Looks good!

[droberts27]

@argush3 FM0000226 , FM0695709 data looks good. Not sure where this displays in the application

[argush3]

@droberts27 FM0314690 output download issue will be fixed in #13050. I already confirmed it works locally.

[argush3]

Moving to done. Outstanding issues will be addressed in other tickets as mentioned in the previous comments.