Additional validations + updates when adding a registration to the dashboard

[RFK250]

Tasks

Models/Validations when adding an existing registration to the MHR table:

• [x] confirmation modal for MHR registration found
• [ ] confirmation modal for child registration of MHR reg found (ie transfer, transport permit reg etc) Need to create new ticket: verifying users can look up a "child" registration (via document registration number) #14425
• [x] error modal for when registration trying to be added is already in the table
• [x] error modal for when system is unable to retrieve existing registration (ie when system is down) - update Victoria office contact number (see design comp)
• [x] add "Remove From Table" dropdown button and modal to remove from table
• [x] update tool tip text beside "retrieve an existing registration to add to your table"
• [x] updating "add existing registration" search field error message/validation in search input field to say "Registration numbers contain 6 digits" - no letters or special characters, only numbers
• [ ] auto-scroll/focus newly added MH registration or child registration, show green row bg and message snack bar, both which fade out on a timer (like PPR) Charles will cover in ticket #13848
• [x] child registration would appear under the parent MH registration
• [x] Hide the "Open" button for MH registrations that are historical and exempt for now (only show for Active registrations)
• [x] If logged in as a qualified supplier and a 3rd party registration is added to their table, display info icon with tool tip (MHR version) instead of the PDF (if logged in as staff, staff can see all of the PDFs)

Design (with text updates)

https://projects.invisionapp.com/share/6F130Q7D4AUB#/screens?browse

Notes

• Users can any existing registration to their table (that hasn't already been added)
• Staff can see all PDFs for registrations manually added to the table but Qualified Suppliers would see the info icon (with tool tip) if they added a registration that their account did not create.

[dimak1]

@tlebedovich should this ticket also include a fix for validation? Currently, the error message says 7 characters are required to do a search when the actual registration number is only 6 digits.

[tlebedovich]

I would say yes. validation should be updated to show error message if user puts in less or more than 6 digits (no letters or special characters) validation message updates to "Registration numbers contain 6 digits"

[dimak1]

@RFK250 should I take this on or leave it for later and work on items in backlog / sprint goal?

[RFK250]

@dimak1 It's still two sprints away potentially and we still need to groom it, so I would say please take from the backlog. Hopefully we can groom this one next week.

[tlebedovich]

@forgeuxGH5 @RFK250 @PatrickAHeath c/c @doug-lovett - We need to know which Reg number should we be using to retrieve registrations other than initial MHR registrations (ie a Transfer). The Document ID number or the Document Registration number? Currently we have a max 6 digit validation set on the retrieve existing field which won't work for Doc IDs (which are 8 digits).

Whichever number we use for this look up is the number we need to display in the table for the Transfer (in addition to it's related MHR number)

[PatrickAHeath]

Staff can search in green screens using MHR #, Document ID or Document Registration #. When beginning a Transfer, they identify the Document ID (from the paper form) and the MHR#, with the Document Registration # being generated once the transaction is complete.

I would choose Document Registration Number to differentiate between transactions within an MHR#.

As for requiring 6 digits to retrieve an MHR into the registrations table, entering 4 digits should be allowed and the system will pad the front with zeroes to 6 digits, just as is done with entering the search parameter for MHR#.

[RFK250]

Thanks @PatrickAHeath - @tlebedovich does that give you what you need?

[tlebedovich]

@owillborn - UXA feedback for ya:

• [x] If user tries to search for an existing registration number that doesn't exist, we should be showing this modal:

but instead it is showing this one:

---

• [ ] And, IF there is a system/app error and the retrieve functionality isn't working properly, then we should show this modal - can you confirm this so I can check the copy is right?

[tlebedovich]

@chdivyareddy - when this is in RFQA, can you check this one - "Hide the "Open" button for MH registrations that are historical and exempt for now (only show for Active registrations)"

[tlebedovich]

ps @owillborn - was this work done for both the Staff and Qualified Supplier views of the table?

[owillborn]

@tlebedovich good catches

[PCC199]

@owillborn is it possible to move this one along...if there are changes to be made, should be in progress, if it's still waiting for review, we need to remind the reviewers.

[tlebedovich]

@chdivyareddy - please test and review the system error modal will appear when there is a system error - was unable to see this modal.

[owillborn]

• please test and review the system error modal will appear when there is a system error - was unable to see this modal.

If you can force a 500 error it should display, just not sure how to do this haha!

[chdivyareddy]

@owillborn , For the Staff account (BRTEST1) in DEV, the child registrations are not sorted under the parent registrations and there is no option to remove the existing registrations from the table. Note: In TEST account for staff(BRTEST1), registrations are sorted and has the option to remove the registration from the table Can you please have a look? thanks! Current Behavior: DEV

Vs Current Behavior: TEST

[dimak1]

Taking a look at the issue Divya raised (to help out Otto).

[dimak1]

After doing some investigation as to why Action buttons are not showing up in DEV is Search History table (but showing up in TEST), I suspect it could be because of the user roles. Specifically mhr_transfer_sale.

Could anyone check if the role mhr_transfer_sale is setup for user BRTEST1 in DEV? @mstanton1 @chdivyareddy

[mstanton1]

@dimak1 the mhr_transfer_sale user role isn't showing for BRTEST1 in DEV. I would expect this role would be assigned by virtue of being added to a group. Does it make sense I add the keycloak group for mhr_qualified_user? Or is there a different user type you are trying to test?

[dimak1]

Thanks @mstanton1 for looking into it. mhr_transfer_sale role represents a Qualified Supplier. This explains why certain features a not available for BRTEST1 in Dev.

I think we should set up this user the same as in TEST that way it is consistent across the environments. @chdivyareddy

[dimak1]

After setting up the roles in DEV the issue with Action buttons is resolved. I'm looking into a sorting issue now.

[dimak1]

Looks like the child/parent filings are showing up now, as we fixed the roles for Qualified Supplier.

@chdivyareddy if this was the last issue in this ticket, then we could send it back to RFQA for a re-retest. Thank you.

[chdivyareddy]

@dimak1 Thank you and Yes, the parent/child registrations are displayed as expected in the table now.

Looks like the 'Remove' functionality is not working as expected on the staff account (BRTEST1), this issue exists in both DEV & TEST and also when 'Open' button is clicked from the dashboard, the transfer page keeps on loading without displaying the MHR info. I wasn't sure whether the staff account should include the Transfer flow as well. Could you please take a look at that?

OR, would you like me to create a separate ticket for this issue?

cc @mstanton1

[dimak1]

Thanks @chdivyareddy; I will look into it.

Since it's a new issue, my thought process is to create a quick new ticket just for that issue and to keep this ticket as is (it already has lots of stuff in it). @mstanton1 thoughts?

[PCC199]

@chdivyareddy and @dimak1. If it is an unrelated issue, this ticket can be moved along and one raised for the new defect. If it is a related defect, it can be rectified in this ticket.

[mstanton1]

A new ticket seems appropriate. The list included adding the removal dropdown but didn't speak to functionality for that dropdown. I can create a new ticket. cc @chdivyareddy @dimak1 @PCC199

[dimak1]

Please assign me that ticket @mstanton1. Thanks!

[mstanton1]

@dimak1 assigned you 14622. Can you move this ticket along?

[mstanton1]

@dimak1 assigned you 14622. Can you move this ticket along?

[dimak1]

Thanks!

[chdivyareddy]

Verified!

• "Open" button is hidden for MH registrations that are historical and exempt (Historical - 081277, Exempt - 045440):