MHR Registration - Mailing Address issue (and PPR address issue)

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 58 forks source link

MHR Registration - Mailing Address issue (and PPR address issue) #13931

Closed chdivyareddy closed 1 year ago

chdivyareddy commented 2 years ago

AC

GIVEN I am BC Registries Staff with the keycloak group Assets_Staff WHEN I am in the Manufactured Home Registration step 2 Submitting Party and step 3 List Home Owners AND if the mailing address is Canadian or non-Canada in step2 and step3 from the Canada post lookup THEN the postal code should be validated without any error message

Note: This has been described as also resolving the same issue with PPR addresses. Please verify.

Current Behavior:

[x] When Canada is selected as a Country, then the lookup displays Unites states address in the dropdown list
[x] When the mailing address Country is United states
[x] When the mailing address Country is Canada

mstanton1 commented 1 year ago

Tackle with https://app.zenhub.com/workspaces/assets-team-space-61426544e7e2ea001d079597/issues/bcgov/entity/13471

ChasBoucher commented 1 year ago

@dimak1 pointed out a valid issue in his review of my code.

The bug has been fixed for this ticket, but the fix does affect any MHR or PPR form that uses the BaseAddress shared component. I did a test on PPR forms that use the BaseAddress and found that the fix I am putting in for MHR also fixed the issue for PPR. I am not sure why it was never reported.

The question is, as Dima pointed out is; should I Change the Description and AC of the ticket to ensure that this ticket describes A bug in the BaseAddress?

dimak1 commented 1 year ago

@ChasBoucher usually developers do not create/update AC's. These requirements should come from PO or Designers. cc: @mstanton1 @tlebedovich pls see above

mstanton1 commented 1 year ago

@ChasBoucher it would be great to have @chdivyareddy test as well to confirm impacts for PPR. If this is resolved for PPR as well great. If not, as long as nothing is broken we can move this along (and then see if user feedback comes in for PPR). I've updated the description.

ChasBoucher commented 1 year ago

@mstanton1 @dimak1 Sounds good. Waiting on one approval and hopefully it will get merged today.

chdivyareddy commented 1 year ago

Hey @ChasBoucher ! Sometimes when Canada is selected as a Country, then the lookup displays Unites states address in the drop-down list and vice versa same as reported above in both places PPR and MHR filings. Please take a look, thanks!!

Steps to Reproduce:

Select a PPR registration to start filing
Navigate to step2 (secured parties and debtors)
Add a secured party
In the mailing address, switch the Country between Canada and the United States of America multiple times.
The drop-down address list displays Canada address for US and US address for Canada.

Follow the same steps for MHR filing as well

PPR Registarion: Secured party Screenshot (97).png

Screenshot (99).png

MHR Registration: Submitting party Screenshot (101).png

ChasBoucher commented 1 year ago

The above error is very difficult to reproduce and usually only happens when the Country code is changed in quick succession... This may be due to a delay in accessing the Canada post API... I am not sure how much time we should spend on this to fix this issue...It has never been reported by a user.

mstanton1 commented 1 year ago

With your note @ChasBoucher that the issue above is very difficult to reproduce I would be comfortable moving forward without tackling it given the likelihood of this occurring is very low.

chdivyareddy commented 1 year ago

@mstanton1 Yes, I do agree with @ChasBoucher on this scenario (which only occurs with change in the Country code multiple times) where this is currently in PROD and never reported by users.

PCC199 commented 1 year ago

Will reopen if it becomes a customer's issue