bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

API - MHR search outputs - unit notes updates #14095

Closed tlebedovich closed 1 year ago

tlebedovich commented 1 year ago

https://app.zenhub.com/files/157936592/7d5f0577-ff29-4b21-bf05-b60f9c60a60a/download

1. Non-Residential Unit Notes should say "Destroyed Date:" instead of "Expired Date:

Screen Shot 2022-10-31 at 1.57.10 PM.png

Screen Shot 2022-10-31 at 1.56.44 PM.png


2. Registrar's Freeze remarks

Screen Shot 2022-11-10 at 11.34.33 AM.png

3. 103 (Transport Permit) and 103E (Extend Transport Permit). 103 (Transport Permit) and 103E (Extend Transport Permit) document types should not display as Unit Notes for any users or staff, they are not Unit Notes.

catherinecarlson commented 1 year ago

I was reviewing the requirements for UNIT NOTES with Sharon M today.

She confirmed that the text that displays below the contact information (name, address, phone #) is NOT part of the UNIT NOTES.

For example, this text is not part of the UNIT NOTES SPECIAL TRANSPORT RESTRICTIONS APPLY TO THIS HOME DUE TO THE WIDTH. PLEASE CONTACT PROVINCIAL PERMIT CENTRE 1-800-559-9688 FOR FURTHER DETAILS.

catherinecarlson commented 1 year ago

I have been working with Sharon M on the UNIT NOTES requirements. I've attached the draft spreadsheet for review. I have a few outstanding questions for Sharon M

https://app.zenhub.com/files/157936592/413e07e1-cfab-40fc-86af-470857c32fc9/download

catherinecarlson commented 1 year ago

Regarding Registrar's Freeze questions above:

Both staff and BCOL users can view Unit Notes for registrar’s freeze. The Remarks added as part of the Unit Notes are added automatically. However, the Remarks section in the unit notes are displayed ONLY for staff. BCOL users do NOT see the remarks. For an example, refer to MH 107069.

These are the remarks added:

SECTION 19(7) OF THE MANUFACTURED HOME ACT HAS BEEN INVOKED. ALL DEALINGS ON THIS MANUFACTURED HOME ARE SUSPENDED.

Refer to the spreadsheet in previous comment Summary of UNIT NOTES V1.1 xlsx.

mstanton1 commented 1 year ago

@catherinecarlson can you update the requirements in the body of the ticket? I've added a comment with your information about Freeze for instance beside the question on freeze. Can you also link the updated spreadsheet in the body? Note, to update the body you would choose edit in the top right of the Zenhub ticket. Thank you!

mstanton1 commented 1 year ago

A more recent version of the unit note spreadsheet has been provided by Catherine. I have replaced the document linked in the main body of the ticket with this recent version.

mstanton1 commented 1 year ago

@catherinecarlson it looks like this is ready for build aside from two questions in your sheet. Row 1 states you need to confirm. Row 10 states it is done by datafix but I believe that was due to an overabundance of caution and to continue to move in a consistent direction (and one that is reliant on system functionality rather than datafix) we should allow staff to complete the REG. CORRECTION. @doug-lovett when you have capacity I'm not sure if this is one you could pass to @owillborn or if it will be something more appropriate for you to tackle?

doug-lovett commented 1 year ago

Dev Notes:

mstanton1 commented 1 year ago

@doug-lovett to your question on the first three rows where the BC Online client can see the remarks and the staff can not we have not been able to identify any practical reason for this logic. Please proceed to build those three scenarios so that staff can see the remarks that BC Online clients can see. Thanks!

doug-lovett commented 1 year ago

DEV mhr numbers for unit testing. TAXN: 006544 status C 075430 status A

CAUC: 019277 no expiry date 080104 2025-03-24 046558 2021-10-15

CAU: 075750 2021-03-03 092238 2023-06-30

CAUE: 075750 2021-04-16 046558 2023-06-30

EXNR: 042476 no expiry 040932 2016-10-13

FZE: 071950 no remarks 067500 remarks

103: 087700, 087703 103E: 078587, 011005

Attached is a single search report with unit notes from mhr number searches on the above mhr numbers.

https://app.zenhub.com/files/157936592/a3ca0e56-d3d0-4074-a2d0-8a590a5d01ec/download

catherinecarlson commented 1 year ago

@doug-lovett REGC - as a followup to Melissa's remark above - Sharon has confirmed that she currently cannot complete an REGC to cancel a registration because she does not have the permission to do so. To do so, she requests a data fix. However, in the new app staff should be able to complete the cancellation.

TAXN - the Remarks section in the Unit Note has been updated when 'Y' is entered. Update the text as follows: If 'N' not changed to 'Y' then a remark is not displayed. If 'N' is changed to 'Y' then remark = A NOTICE PURSUANT TO SECTION 457/464 OF THE MUNICIPAL ACT WAS FILED

FZE - this document type code is not required in the modernized application

owillborn commented 1 year ago

@doug-lovett @catherinecarlson looks good through testing, although I found one scenario where the "Remark" text is different when I believe they should be the same.

The CAUC for reg 007116: image.png

and for reg 035159: image.png

Please take a look, thanks!

catherinecarlson commented 1 year ago

@owillborn @doug-lovett

I think this is what should display for CAUC:

IF MHOMNOTE.DOCUTYPE = 'CAUC' & MHOMNOTE.EXPIRYDA = '0001-01-01' THEN FORMATTED_DATA(#LINE + 1) = ('Continued until further order of the court.');

Else typing in a remark is optional

doug-lovett commented 1 year ago

@owillborn @catherinecarlson The unit note remarks and the registration description other remarks are different database table columns and may be different values.

I see the issue now: the text is appearing twice. In Catherine's spreadsheet, the automatic text is just a comment - not instructions to add text to the report.

owillborn commented 1 year ago

@catherinecarlson @doug-lovett so we can move this along to RFQA?

doug-lovett commented 1 year ago

@catherinecarlson can you please confirm this change in the most recent spreadsheet: Although once a caution has expired, the Unit Notes should not be displayed. Same for Extension and continue extension. Do you mean do not display the remarks, or do not display the entire unit note?

doug-lovett commented 1 year ago

@owillborn leave as is, the duplicate text should be removed.

owillborn commented 1 year ago

@doug-lovett sounds good, thanks for clarifying

catherinecarlson commented 1 year ago

@doug-lovett @owillborn I am not 100% sure that the Unit Note should not display when the caution/etc. has expired. Or just the remark. I documented it in the spreadsheet that the Unit Note doesn't display but I'd like to double-check with Sharon tomorrow.

catherinecarlson commented 1 year ago

@doug-lovett Yes, the changes that I listed above (earlier this morning) are the only changes that I've made to the spreadsheet. I'll ask Melissa to post it tomorrow in the body of this issue as I don't have access.

Would you like me to email you a copy now? Or attach it to a comment for this issue?

catherinecarlson commented 1 year ago

@doug-lovett I confirmed with Sharon this morning that once CAU, CAUC and CAUE have expired the UNIT NOTES should not display for all users.

doug-lovett commented 1 year ago

Search results updated to remove CAU, CAUE, CAUC if expiry has elapsed.

chdivyareddy commented 1 year ago

Hey @doug-lovett , when the 'Expired Date' for the 'CONTINUE CAUTION' is N/A, then the Remarks should read as 'Continued until further order of the court.' But, it's currently displayed as N/A. Can you please take a look for MH Number: 019277 in DEV

image.png

doug-lovett commented 1 year ago

@chdivyareddy the report only displays the remarks: some CAUC notes where there is no expiry do not have remarks, including this one. Here are some that do have remarks:

071242 CONTINUED UNTIL FURTHER ORDER OF THE COURT 071243 CONTINUED UNTIL FURTHER ORDER OF THE COURT. 068196 CONTINUED UNTIL FURTHER ORDER OF THE COURT. 002400 COURT REGISTRY ACTION NUMBER: 42399 VERNON REGISTRY CONTINUED TILL FURTHER ORDER OF THE COURT 063475 UNTIL FURTHER ORDER OF THE COURT 060842 CONTINUED TILL FURTHER ORDER OF THE COURT 043814 CONTINUED UNTIL THE TRIAL OF THIS MATTER OR BY AGREEMENT OF THE PARTIES. 048814 UNTIL FURTHER ORDER OF THE COURT 046837 COURT REGISTRY ACTION NUMBER E2974 - 041606 CONTINUED UNTIL FURTHER ORDER OF THE COURT. 039380 SUPREME COURT ORDER, CRANBROOK REGISTRY, NO. 14003 037697 CONTINUED UNTIL FURTHER ORDER OF THE COURT 035159 THIS CAUTION IS CONTINUED UNTIL FURTHER ORDER OF THE COURT.

chdivyareddy commented 1 year ago

@doug-lovett Thanks for clarifying:)

chdivyareddy commented 1 year ago

@catherinecarlson @doug-lovett , Quick question from the spreadsheet - Document types NCON (Confidential Note) and 102 (Decal Replacement), can non-staff view the notes? From the spreadsheet it says 'No', but currently the notes are displayed for non-staff. Does this mean only registration status with Active status 'A' can view the notes for non-staff? Can you please take a look, thanks!

Eg: MHR Number: 106168 - Decal Replacement MHR number: 035159 - Confidential Note

doug-lovett commented 1 year ago

@chdivyareddy I missed those updates (also missed in my dev notes above).

chdivyareddy commented 1 year ago

@doug-lovett Thanks for checking! @catherinecarlson would like to check on Document type REGC (Registrar's Correction) spreadsheet displays 'No' for non-staff , but under the 'Remarks' section the description says 'if a remark is added automatically then it should be displayed to all users (staff and non-staff)'. Can you please confirm and update the spreadsheet, thanks!

MHR number: 101010

doug-lovett commented 1 year ago

@chdivyareddy the update for the NCON and 102 document types is now in DEV.

chdivyareddy commented 1 year ago

Thanks @doug-lovett !

Verified the NCON and 102 Document types that Remarks are not displayed for non-staff account.

catherinecarlson commented 1 year ago

@doug-lovett @chdivyareddy For NCON and 102, the current behaviour for non-staff is that UNIT NOTES (with remarks) are not displayed.

I'm sorry but the spreadsheet was not accurate. Refer to MH #107077.

catherinecarlson commented 1 year ago

@chdivyareddy @doug-lovett

For REGC when status of the MH registration is changed to cancelled automatically add the following remark: MANUFACTURED HOME REGISTRATION CANCELLED. This should be displayed to staff and non-staff.

For all remarks typed in manually by staff for all other corrections (location/owner, etc.) do not display them to nonstaff. Only to staff.

catherinecarlson commented 1 year ago

@chdivyareddy @doug-lovett I'll send the updated spreadsheet to Melissa as I can't edit the body of this ticket.

I've made updates to NCON, 102 and REGC.

mstanton1 commented 1 year ago

Note: Spreadsheet has been updated in the body of the ticket to link to Catherine's most recent version.

doug-lovett commented 1 year ago

@DivyaC REGC DEV MHR numbers; 016211 015709 015097 015213 015215 015216 014384 050973 050666 050400 012478 049227 012179 011811 011178 010053

chdivyareddy commented 1 year ago

@doug-lovett Thank you! REGC is working as expected for Staff and Non-staff.

MHR Number: 012179

Staff: https://app.zenhub.com/files/157936592/cb77ff0d-8fba-463c-afcc-a031ca902c0d/download Non-staff: https://app.zenhub.com/files/157936592/fd0e50db-eebc-4a1b-ab1f-1a70c6569d2b/download

doug-lovett commented 1 year ago

@chdivyareddy the change to exclude NCON, 102 for non-staff is now in DEV.

chdivyareddy commented 1 year ago

@doug-lovett Thank you!

Verified in DEV for Staff and Non-staff!

CAU - Caution Staff: 075750 2021-03-03 (Unit notes are not displayed) https://app.zenhub.com/files/157936592/93ff66f7-9327-4772-9b03-8393ab66ca3c/download 092238 2023-06-30 (Unit notes are displayed) https://app.zenhub.com/files/157936592/5e4254bb-8824-415a-b98d-f40249017f5f/download Non-staff: 075750 2021-03-03 (Unit notes are not displayed) https://app.zenhub.com/files/157936592/18245039-185c-41a9-8b0b-16a1f2f5e46b/download 092238 2023-06-30 (Unit notes are displayed) https://app.zenhub.com/files/157936592/22b6cfd7-9fa1-4cea-b006-f1d91e939cc4/download

CAUC - Continue Caution Staff: 071242 no expiry date https://app.zenhub.com/files/157936592/5f6ca851-e29f-48b4-9339-406da4e9b6ff/download 080104 2025-03-24 https://app.zenhub.com/files/157936592/ae6971c0-f0ad-4a1b-9519-c6bd2c876333/download 046558 2021-10-15 https://app.zenhub.com/files/157936592/fd3c030e-bf38-4d1d-8dd4-b4109fd6c6a1/download Non-staff: 035159 no expiry date https://app.zenhub.com/files/157936592/1ce103cc-2d20-442b-a8c5-19468c155730/download 080104 2025-03-24 https://app.zenhub.com/files/157936592/77cc108e-d0f4-487a-9fe8-9c8a373156d8/download 046558 2021-10-15 https://app.zenhub.com/files/157936592/37bebd3e-638b-409c-9c7e-4b79409d3fad/download

CAUE - Extend Caution Staff: 075750 2021-04-16 https://app.zenhub.com/files/157936592/5b1940ca-dad8-428c-8262-5ce200438134/download 046558 2023-06-30 https://app.zenhub.com/files/157936592/ff9dd564-b959-4142-9a10-7448af6c4405/download Non-Staff: 075750 2021-04-16 https://app.zenhub.com/files/157936592/5ba2481f-3a3a-4b7d-990f-22315dbe2526/download 046558 2023-06-30 https://app.zenhub.com/files/157936592/63482129-cdf6-4dc5-a6df-4ca60da53c50/download

EXNR - Non-Residential Exemption Staff: 042476 no expiry https://app.zenhub.com/files/157936592/cd5100ae-dcd5-4ab0-8bfa-7836331ddd81/download 040932 2016-10-13 https://app.zenhub.com/files/157936592/92a8eaf7-8aeb-4ded-8493-3f4f6627213f/download Non-staff: 042476 no expiry https://app.zenhub.com/files/157936592/f84bde14-022e-4b11-b2db-cbd7caab66f5/download 040932 2016-10-13 https://app.zenhub.com/files/157936592/2930768b-2b1b-4ec7-ba01-220b2eaf9c6e/download

EXRS - Residential Exemption Staff: 080910 https://app.zenhub.com/files/157936592/a33b9355-d290-466d-b455-ec159f3e3531/download Non-staff: 080910 https://app.zenhub.com/files/157936592/e72aff4c-85c0-4dd0-9413-a2dae83fe636/download

FZE - Registrar's Freeze Staff: 071950 no remarks https://app.zenhub.com/files/157936592/ad429e2f-b061-4953-a604-9e37f924732b/download 067500 remarks https://app.zenhub.com/files/157936592/78a68db2-e44f-49c3-8d3e-71b1b1d6441b/download Non-staff: 071950 no remarks https://app.zenhub.com/files/157936592/c4dfdd64-5704-488a-8368-228dc8187cfc/download 067500 remarks https://app.zenhub.com/files/157936592/5105fa3e-3f39-4acc-b7cd-bb52a7349dc4/download

NCON - Confidential Note Staff: 035159 (Unit notes are displayed) https://app.zenhub.com/files/157936592/9d80713c-be57-4525-a376-cd4bea65ee4a/download Non-staff: 035159 (Unit notes are not displayed) https://app.zenhub.com/files/157936592/04f4c513-7cdb-4233-bceb-f85215832175/download

NPUB - Public Note Staff: 104054 https://app.zenhub.com/files/157936592/26ad951b-27b2-4ac1-907c-4ab531bab2c8/download Non-staff: 104054 https://app.zenhub.com/files/157936592/38ce775f-b93c-4848-aa97-57723c8c6ce8/download

REGC - Registrar's Correction Staff: 012179 https://app.zenhub.com/files/157936592/07de359f-b574-4c69-8574-3433a6f831eb/download Non-staff: 012179 (if the remark is typed in by staff manually then the remark should NOT be displayed to non-staff) https://app.zenhub.com/files/157936592/4f12d78d-cd05-4385-884a-b34fcb1dc7f7/download

REST - Restraining Order Staff: 013967 https://app.zenhub.com/files/157936592/e339738c-642e-4143-82ae-d5c906eb670d/download Non-staff: 013967 https://app.zenhub.com/files/157936592/c4f7ce28-586a-4b02-96af-86bcfe64707e/download

TAXN - Tax Sale Notice Staff: 006544 status C https://app.zenhub.com/files/157936592/b2c8cbc3-5ede-490f-8461-6b4274127351/download 075430 status A https://app.zenhub.com/files/157936592/7a4e5b2a-e3e9-4ac5-b3c7-031299f8e964/download Non-staff: 006544 status C https://app.zenhub.com/files/157936592/e342cd16-6532-4358-ad95-4fc3aebd3c97/download 075430 status A https://app.zenhub.com/files/157936592/67d07a6f-e697-4d9e-8be8-cce41b4f588f/download

102 - Decal Replacement Staff: 106168 https://app.zenhub.com/files/157936592/a6f1ec25-1e9b-4df4-83ff-27f8d53809ee/download Non-staff: 106168 https://app.zenhub.com/files/157936592/f2ba60dc-5684-426c-8337-80e5fa58e468/download

103 - Transport Permit (Documents do not display unit notes): Staff: 087703 https://app.zenhub.com/files/157936592/5276781a-1b2a-4362-b946-f45750eba81c/download Non-staff: 087703 https://app.zenhub.com/files/157936592/7bde786b-038c-437e-968e-967b3a99f25d/download

103E - Extend Transport Permit (Documents do not display unit notes): Staff: 078587 https://app.zenhub.com/files/157936592/7bec5fbe-5043-43b8-984c-f3522f7533a6/download Non-staff: 078587 https://app.zenhub.com/files/157936592/330acc43-d3bf-4df7-b182-84464d2a2097/download

chdivyareddy commented 1 year ago

TEST:

CAU - Caution 107032 Staff: (Unit notes are displayed) https://app.zenhub.com/files/157936592/ca8ea504-7498-497b-a504-79db1eca76e6/download 107032 Non-staff: (Unit notes are displayed) https://app.zenhub.com/files/157936592/7ba1c6fb-c206-4041-a1e1-9d4a46af790b/download

CAUE - Extend Caution 107033 Staff: (Unit notes are displayed) https://app.zenhub.com/files/157936592/8210697a-caab-4676-9e5f-b987e16abcdc/download 107033 Non-staff: (Unit notes are displayed) https://app.zenhub.com/files/157936592/2b9bcc10-1668-43f3-bf93-363570c985e6/download

EXRS - Residential Exemption 107067 Staff: (with Remarks) https://app.zenhub.com/files/157936592/3054ff42-b9e9-4510-963a-3997a12297eb/download 080910 (without Remarks) https://app.zenhub.com/files/157936592/0e4ae8a2-8bea-4288-b3fe-4b3c4348497f/download 107067 Non-staff: (with Remarks) https://app.zenhub.com/files/157936592/86f33b70-6abb-4bbb-876a-72e5af123cf1/download 080910 (without Remarks) https://app.zenhub.com/files/157936592/2c19933f-cb28-4984-9e56-320a99b141bb/download