bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

UI - Rules - non-schema address rules #1472

Open severinbeauvais opened 4 years ago

severinbeauvais commented 4 years ago

This task is the remaining, lower-priority work from task #1191.

Description:

Sub-task of #757.

  1. Registered Office Address -- Delivery Street Address and Address Additional cannot be a PO Box (or any variation) -- Mailing Street Address can be a PO Box -- Street Address is optional if Delivery Instructions have data

  2. Director Address -- Residential Street Address and Address Additional cannot be a PO Box (or any variation)

Here's the address component UI interactions and behaviours: https://preview.uxpin.com/4b25823c7cd7665bf23cc3880a232397d6894169#/pages/115375364

Dependencies

Acceptance Criteria Rules above should be functional.

Validation Rules

Ready to Build (DoR):

Acceptance / DoD:

severinbeauvais commented 4 years ago

Currently blocked by lack of validation rule for "what is a PO Box (or any variation)?"

Suggested examples that should be rejected: P.O. Box P.O.Box P O Box PO Box POBox P.O.B. POB Post Office Box PostOffice Box PostOfficeBox (also examples with multiple spaces)

What about "Box 123" or "P-O Box" or "Post-Office-Box"?

forgeuxGH5 commented 4 years ago

I think we should also include not allowing the digit "0" in place of the letter "O". The paper form also includes other types of addresses that are not valid so we need to know how to handle these. From the paper form: “Enter the complete physical address. You may include general delivery, post office box, rural route, site or comp. number as part of the address, but the Corporate Registry cannot accept this information as a complete address. You must also include a postal code. If an area does not have street names or numbers, provide a description that would readily allow a person to locate the office.”

severinbeauvais commented 4 years ago

I unassigned this from me as this ticket is not ready to implement.

severinbeauvais commented 4 years ago

As discussed with @Kaineatthelab, @lmcclung, @sienna-freshworks and @forgeuxGH5:

  1. the requirement to reject an address that is a PO Box is not needed at this time
  2. the requirement for "one of [streetAddress, deliveryInstructions] is required" is not needed at this time

As a result of this, I am adding label Priority 3 and moving this ticket to the backlog.