bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

BE - make a limited restoration historical again #14816

Open severinbeauvais opened 1 year ago

severinbeauvais commented 1 year ago

When a limited restoration's expiry date is reached, it needs to be made historical again.

Questions:

To Do:

Ref: Dissolve Expired Limited Restotations

jdyck-fw commented 1 year ago

This ticket is dependant on the state model.

jdyck-fw commented 1 year ago

For involuntary resolution we can look at an RFC for batch jobs, for this one we will have Thor review the work.

jdyck-fw commented 1 year ago

@davemck513 will connect with @thorwolpert to discuss this.

jdyck-fw commented 8 months ago

This should likely happen after the migration to GCP.

NaveenHebbale commented 8 months ago

@thorwolpert Can we / should we reuse existing batch job? What will happen after GCP implementation

thorwolpert commented 8 months ago

If the existing job is just a container that gets executed (if it uses standard k8s cronjob) then it becomes a CloudRun Job and gets scheduled in CloudScheduler. CloudScheduler is maintained by the SRE team, so you just need to let them know the name of the job and they will schedule it in. Best to open a tix for the SRE team so that it gets tracked as a dependency.

severinbeauvais commented 8 months ago

This ticket has some big questions in it:

Then, we can implement what's needed and get it configured into CloudScheduler as Thor has described.

NaveenHebbale commented 8 months ago

@argush3 @OlgaPotiagalova

thorwolpert commented 8 months ago

Ideally the business is closed again with a dissolution filing. Having an end of life filing is helpful for any future restoration processes. There are a few ways a business is dissolved that block it from being restored - or at least a self-serve restoration.

NaveenHebbale commented 8 months ago

Input from Argus [3:33 PM] Chiu, Argus 1 CITZ:EX i talked to Thor a bit and i think we can create a new batch job for dissolutions. we can use the existing dissolution schema. one of the outstanding questions is which existing dissolution type do we want to use for these dissolution filings. [3:33 PM] Chiu, Argus 1 CITZ:EX https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/dissolution.json#L22-L31 business-schemas/src/registry_schemas/schemas/dissolution.json at main · bcgov/business-schemas Manages the JSONSchemas for the BCRegistry Legal Filings. - bcgov/business-schemas [3:34 PM] Chiu, Argus 1 CITZ:EX We have involuntary which is typically system driven and there is also administrativewhich is typically done by staff. i'm assuming we use involuntary but you can confirm with the business what they want.

severinbeauvais commented 2 months ago

Blocked on requirements.

I added @davemck513 's team label as this is related to GCP and batch jobs.

vikas-gov commented 1 month ago

Needs further discussion before it can be estimated.

severinbeauvais commented 1 month ago

Per @Mihai-QuickSilverDev , a limited restored business just becomes historical again -- no need for involuntary dissolution flow.

@davemck513 @JazzarKarim @argush3 Does your involuntary dissolution flow specifically ignore businesses that are active but limited restored?

argush3 commented 1 month ago

Yes, involuntary dissolution flow will ignore businesses that are in limited restoration status.

Involuntary dissolution eligibility criteria

image.png