search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

Unable to request NR's that involve lookup of a corporation number #15088

Closed Mihai-QuickSilverDev closed 1 year ago

Mihai-QuickSilverDev commented 1 year ago

Describe the bug in current situation

image.png Steps to Reproduce Steps to reproduce the behavior:

  1. Name Request in Test
  2. Launch a NR that requires to enter an entity number - name change, restoration, etc.
  3. Enter that entity number and click Submit
  4. Observe the error
Mihai-QuickSilverDev commented 1 year ago

Mihai to follow-up with Travis.

PCC199 commented 1 year ago

@Mihai-QuickSilverDev . is this the same as: Namex API: shouldn't crash (500) on invalid Corp Num#15026

Mihai-QuickSilverDev commented 1 year ago

Hi Paddy,

15088 is different from #15026. #15088 refers to the inability of the Names application to run a lookup on a valid corporation number.

15026 deals with what sort of message we should display if we run a lookup on an invalid corporation number.

Thank you,

Mihai Dinu

Mihai-QuickSilverDev commented 1 year ago

@PCC199 @eve-git @ozamani9gh @pwei1018 @seeker25 Hi All, talking to Severin about this, this could be easily fixed by applying a setting in Names Test, which was applied in Dev, but is missing in Test. This functionality works okay in Dev. This is taking a dent in Test on our ability to test and train, and your team's help in addressing it is greatly appreciated. @davemck513 @jdyck-fw @severinbeauvais

Mihai-QuickSilverDev commented 1 year ago

This is a pure SRE ticket, and a high priority as it is blocking the Entity's ability to perform regular work. This was caused potentially by environment work done, and was already fixed in Dev, by SRE personnel. See notes above. Nobody from Entities team is assigned to this work.

@pwei1018 @davemck513 @ozamani9gh @severinbeauvais

ozamani9gh commented 1 year ago

@pwei1018 .

can you point me to the right direction on this.

i don't see any environment variables in DEV or Test for Name Request: image.png TEST: image.png.

I checked NAMEX Environment variables and i see a huge list. image.png Do you know anything about this - 'and was already fixed in Dev, by SRE personnel. ' - Mihai

what secret was changed in DEV but not TEST, is there an easy way to find out, or should i start digging in the code for this one.

Call me on Teams if you have time to chat about this one.

Mihai-QuickSilverDev commented 1 year ago

@seeker25 Hi Travis, could you please shed some light on this? Severin mentioned that you are familiar with solving a similar problem in Dev. The issue is that in Test, all NR requests that involve a corporation lookup, fail. Your help is much appreciated. @severinbeauvais

seeker25 commented 1 year ago

First one worked.. second one didn't:

image

seeker25 commented 1 year ago

I've tried rolling out colin-test in the namex test namespace. Testing now..

seeker25 commented 1 year ago

Should be working now: image

ozamani9gh commented 1 year ago

@seeker25 thank you so much, so rolling out COLIN-TEST in test namespace fixed it...thank you

seeker25 commented 1 year ago

Yup namex-test namespace. (exists in LEAR-test namespace as well)

Mihai-QuickSilverDev commented 1 year ago

URGENT!! HELP NEEDED!!!

Hi Travis and Omid, unfortunately, this issue was not fixed yet. The restoration NR returns this error inserted here. Not knowing where the search is done, Lear or COLIN, I have tried both, and to no avail. We are at a point now where this bug is halting development and testing. Your HELP is Greatly Needed!!! image.png @seeker25 @ozamani9gh @severinbeauvais

ozamani9gh commented 1 year ago

@Mihai-QuickSilverDev the screenshot above is from DEV. can you let @seeker25 know if it works in TEST?

or is it broken in DEV and TEST?

severinbeauvais commented 1 year ago

@Mihai-QuickSilverDev @ozamani9gh I, too, experience this almost every time in DEV. But if you click Review and Confirm a second time, it usually works. Sometimes you have to click it a third time. It seldom works the first time.

I just tried creating a Name Change NR in TEST and it succeeded the first time, quickly. But maybe I got lucky and the second, third... tenth one will still time out. 🤷‍♂️

Update: I just did a second one, worked right away in TEST.

Update 2: I just did one in DEV -- worked right away. Did something get fixed or are the electrons just flowing well today?

Mihai-QuickSilverDev commented 1 year ago

@severinbeauvais Could you try a Restoration NR also?

severinbeauvais commented 1 year ago

I'm glad you asked. The first time I clicked on Review and Confirm, I got an error after about 30s. The second time, it worked right away.

So it looks like Dev and Test and behaving the same: error at first (most of the time), and works the second time (mostly).

image

Mihai-QuickSilverDev commented 1 year ago

IT DOES NOT WORK. I cannot pass this error: image.png

severinbeauvais commented 1 year ago

^^ if this is the one you showed me, this business does not exist in Dev

Let's keep looking at this one on one, and then we can add useful info to this ticket.

seeker25 commented 1 year ago

I rolled out the colin-api pod in DEV

seeker25 commented 1 year ago

Works for me: image

seeker25 commented 1 year ago

Someone should probably figure out why the Colin API loses connection and has critical worker timeouts. Probably someone from SRE?

Mihai-QuickSilverDev commented 1 year ago

Right now Names does not even start in Dev, is down.

seeker25 commented 1 year ago

image

Works for me?

Hmm tried again: image

severinbeauvais commented 1 year ago
  1. Namerequest not Name Examination
  2. You may be loading a cached version
seeker25 commented 1 year ago

Yup, sorry lol

severinbeauvais commented 1 year ago

Excellent example. @seeker25 @ozamani9gh , FYI.

Now, if you try a second or third time, does it work?

severinbeauvais commented 1 year ago

Also, try one of the businesses from the list that isn't "in use".

Mihai-QuickSilverDev commented 1 year ago

We might have another issue. The system detects that the bc corp was already used by another NR. However, the error message displayed makes it impossible to determine that. I have tried BC0814580, and it worked. Most likely because I was the first trying to use it.

severinbeauvais commented 1 year ago

@Mihai-QuickSilverDev You deleted your comment, and I can't remember the business you were trying to link (that failed), so I can't investigate this.

ozamani9gh commented 1 year ago

@seeker25 created a ticket to investigate your question: https://app.zenhub.com/workspaces/sre-team-space-61685e965bfb35001dac5771/issues/gh/bcgov/entity/15520

@severinbeauvais please let me know if this still requires coding changes from SRE or if the COLIN-API fixes have solved the issue.

Thanks

severinbeauvais commented 1 year ago

@Mihai-QuickSilverDev I don't think there is code to determine whether a corp number is already used by NR. I think you can create many NRs for the same corp.

I still think the above issue was caused by either:

So I think this particular issue is no longer happening.

ozamani9gh commented 1 year ago

@Mihai-QuickSilverDev are you happy with Severin's answer, if so i will move this ticket to Done on SRE board.

Mihai-QuickSilverDev commented 1 year ago

Further testing completed today shows that this issue is now satisfactorily resolved. Closing this ticket.