bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

Func & UI -Switch Address Component on Dashboard to yellow UI when COA is Pending #1511

Closed sienna-oldaccountdontuse closed 4 years ago

sienna-oldaccountdontuse commented 5 years ago

Background When a COA gets filed, it is effective at 00:01 PST???? the next day (FOR BCORPS). This prevents users from doing any other filings during this time. We need a visual indicator to show the user that they currently have a COA pending. This ticket is to implement the functionality, so the new UI is shown when there is a COA pending.

Acceptance Criteria

cameron-eyds commented 5 years ago

Bulk of the work is complete but pending some back end work to be approved and merged to be complete. Refer to ticket #1389.

ghost commented 4 years ago

QA Comments

Functionality works fine. But there are some differences between the designs and actual implementation.

Designs: Screen Shot 2020-01-03 at 4.00.20 PM.png

Actual Implementation Screen Shot 2020-01-03 at 12.59.58 PM.png

@cameron-freshworks @scott.Davis Your comments are needed here. Please!

sienna-oldaccountdontuse commented 4 years ago

@Kaineatthelab @forgeuxGH5 I think the implemented text is correct, and is consistent with other designs? And Billin's old designs are now outdated? Please correct me if i am wrong!

ghost commented 4 years ago

Discussed with @forgeuxGH5 and he will create a mock up so that @cameron-freshworks can change it. Not moving it to done.

forgeuxGH5 commented 4 years ago

Here's a quick mock-up - make the status "FILED AND PENDING (filed by test on 2020-01-02)" with the alert triangle after the status text.

Filed and Pending Recent List

cameron-eyds commented 4 years ago

@forgeuxGH5 Excellent, thank you. Will update Asap!

cameron-eyds commented 4 years ago

@cameron-freshworks Friendly reminder from myself to update to most recent design!

cameron-eyds commented 4 years ago

This ticket has been moved to done and the work to update the design has been captured in ticket: https://app.zenhub.com/workspaces/entity-5bf2f2164b5806bc2bf60531/issues/bcgov/entity/2331