bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

BCRS shared components: cannot accept Correct Name after toggling options #15469

Open severinbeauvais opened 1 year ago

severinbeauvais commented 1 year ago

This is an inherent design error in the "correct-name" component (which was ported from Edit UI and is used in Create UI), and fixing it is out of scope for #14783.

To reproduce:

  1. start a restoration filing
  2. expand "Use the incorporation number as the name" form and click the checkbox
  3. expand "Use a name request number" form and enter NR data
  4. re-expand "Use the incorporation number as the name" form
    • observe that checkbox is still checked
    • click Done -- observe that nothing happens
  5. re-expand "Use a name request number" form
    • observe that NR data is still populated
    • click Done -- observe that nothing happens

The error is that the forms should be cleared between expansions above... Or, valid forms should be submittable. However, this requires each form to know when it is expanded or collapsed, and the current design doesn't handle this.

Workaround:

jdyck-fw commented 1 year ago

@Mihai-QuickSilverDev to consider an epic for this