UI & Func - Change "Certify" component for each entity

sienna-oldaccountdontuse commented 5 years ago

*edited estimate due to different approach. Was not worked on at 100% capacity initially.

Description:

In a filing, there can be the "certify" component before you complete the filing. Because this component is different depending on the entity, we need to modularize it and show different text depending on the entity. The certify component will not differ between filings for an entity. A BCorp will see the same text in the certify component, no matter the filing.

The template for this section is:

I, [NAME], certify that I have relevant knowledge of the [ENTITY] and that I am authorized to make this filing.
Note: It is an offence to make a false or misleading statement in respect of a material fact in a record submitted to the Corporate Registry for filing. See section [SECTION] of the [RELEVANT ACT FOR THE ENTITY].

The [NAME] section changes depending on the name that is entered in the legal name field.
The [SECTION] changes depending on the entity type, AND filing type
The [RELEVANT ACT FOR THE ENTITY] changes depending on the entity type
The [ENTITY] changes depending on the authenticated entity type see attached image for what is what

ACTS:

Cooperatives Assocation Act

Business Corporations Act

Acceptance Criteria

Show one set of text if the entity filing is a Co-op
Show another set of text if the entity filing is a BCorp
The above AC applies to all filings that contain a "certify" component

sienna-oldaccountdontuse commented 5 years ago

ghost commented 4 years ago

QA Comments

Tested this functionality. Found some minor bugs. Please refer the image attached

Screen Shot 2019-12-24 at 1.55.20 PM.png

ghost commented 4 years ago

QA Comments Also, the template described in the above ticket does not have any date inside the certify section. Please provide you comment. @Scott.Davis @peter-freshworks @sienna-freshworks

sienna-oldaccountdontuse commented 4 years ago

typo should be fixed as follows: Benefits Company > Benefit Company Inrespect > in respect

@forgeuxGH5 @Kaineatthelab am i correct? also, can you speak to Nitin's question above regarding the date in the certify section? What is it for?

forgeuxGH5 commented 4 years ago

Yes - should be "Benefit Company" Yes - should be 'in respect" Also - for a Cooperative the act is the "Cooperative Association Act" - no "s" on Cooperative

I put a date there to align to the paper form mostly - I'm not sure if we need it legally - Societies Online doesn't have a date there. But it does feel like to me as a user that there should be a date there - we don't show the submission date anywhere in the UI currently otherwise.

If we have the date, it should have a label, i.e., Date: 2019-12-24

Also, unless it's already been handled in a separate ticket, we need to include the instructional text as part of this component since the [FILING TYPE] is also a parameter. It looks like in the current release is is hard coded to "Annual Report".

So we should also have:

Certify Correct Enter the name of the current director, officer, or lawyer submitting this [FILING TYPE].

peter-freshworks commented 4 years ago

@forgeuxGH5 I don't see [FILING TYPE] in the instructions template, where would that go?

forgeuxGH5 commented 4 years ago

I guess it depends where we place the boundaries of the component - I don't really know from a dev standpoint which way makes more sense. The Certify section seems consistent enough across entities that it could include the Section Heading and the instructional text.

So if it makes sense to do it that way, we'd have to expand the instruction template to include the Section heading and instructional text. @sienna-freshworks

How ever we do it, the instructional text needs to include the Filing Type for each filing.

sienna-oldaccountdontuse commented 4 years ago

I can clear up the definition for you, review it with Kaine/ @forgeuxGH5 /Linda, and have something for you @peter-freshworks and @nitin-freshworks to work with by EOD! I will update you guys in this ticket.

sienna-oldaccountdontuse commented 4 years ago

UPDATE @peter-freshworks @nitin-freshworks

This ticket will move back to "in progress" to edit the following text:

Benefits Company > Benefit Company
Inrespect > in respect
Cooperative Associations Act > Cooperative Association Act (Not sure if you implemented it with or without the S, please double check!)

#2252 was created to update the designs based on Scott's new layout he will make, and also up modularize the instruction text for that component to display the [filing type] of that filing.
Scott will create a ticket to track his work on a new layout for the certify correct component. He will link the new ticket on this ticket, and also block #2252 with this design ticket as well.

severinbeauvais commented 4 years ago

QA moved this to Ready for QA so they know to look at it.

The normal process is that the developer tests this once it is deployed to Dev, and if OK then they move it to Ready for QA.

In this case we are are trying to close off this release and perform final testing so QA decided that they will just look at anyway.

JohnamLane commented 4 years ago

Coops verified in Test. @nitin-freshworks when you get a chance, please confirm that bcomp looks good as well.

ghost commented 4 years ago

Moving it to done. Scott created a new ticket for this #2252

bcgov / entity