Create UI: New Default State for Restoration Type

[JazzarKarim]

As it currently stands, when we create a new restoration, a full restoration draft is created. (The user can easily change this in the UI.)

UX team wants a new default state in which no restoration is selected.

Note that having "no" type set initially may cause some components to display incorrectly. There may also be other dependencies on the restoration type. This is why we start with an initial type.

SB says: This is fixable but potentially a lot of work. Is it worth it?

[jdyck-fw]

When we create a draft, we give it a type. Which could add some complications to this.

[OlgaPotiagalova]

Leave it for now. Follow up with the UX team, but is low priority

[severinbeauvais]

deleted obsolete comment

[severinbeauvais]

deleted obsolete comment

[severinbeauvais]

@OlgaPotiagalova deleted obsolete comment

[severinbeauvais]

Test Notes

In Filings UI, try:

• new restoration (no type initially)
• resume restoration draft with no type selected yet
• resume limited restoration draft
• resumt full restoration draft
• new limited restoration extension
• resume limited restoration extension
• new limited restoration conversion
• resume limited restoration conversion

In Create UI, try:

• validation on new restoration (no type) before visiting Review page (ie, validation is disabled)
• toggle between restoration types before visiting Review page (ie, validation is disabled)
• validation on new restoration (no type) after visiting Review page (ie, validation is now enabled)
• toggle between restoration types after visiting Review page (ie, validation is now enabled)

[jacqueline-williams-549]

This looks great, I was wondering if the spacing between the Restoration Type radio buttons and the spacing between the Approval Type radio buttons could be the same? My preference is to lessen the space between the approval type radio buttons so that they align with Restoration Type.

[jacqueline-williams-549]

Severin made several updates in response to my comment and I've approved the spacing within the restoration type section.

[severinbeauvais]

Updated Screenshots

No approval type selected.

Court order type selected.

Registrar type selected.

[severinbeauvais]

I also fixed the registrar approval type that wasn't showing validation errors until each text field was touched. Now it shows errors as soon as the validation flag is enabled:

[severinbeauvais]

I found another bug that I will fix in this ticket: the court order is not being saved (or restored)...

[severinbeauvais]

The above bug is now fixed.

I also fixed another bug where the registrar type was being restored only if both dates were previously saved. Now, if either date was entered, the registrar type is restored from draft.

[severinbeauvais]

Another bug has been found and will be fixed in this ticket:

And it's the same thing if an approval type of "court order" is used.

The problem is that approvalType is not being set in the object and stored in the JSON. The reason is that the ApprovalType component is watching for the wrong event from the sub-component. The event should be approvalTypeChange (not radioButtonChange).

[severinbeauvais]

The bug is fixed. (Thanks, Arwen!)

Riyaz, back to you, please and thanks!