bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 57 forks source link

UI - Validations (WILL) #15575

Closed mstanton1 closed 1 year ago

mstanton1 commented 1 year ago

WILL transfer flow validations

tlebedovich commented 1 year ago

@dimak1 - just putting the misc UXA we talked about in here for you --

Screen Shot 2023-04-04 at 11.33.40 AM.png

Screen Shot 2023-04-04 at 11.41.53 AM.png

Screen Shot 2023-04-04 at 11.46.04 AM.png

Screen Shot 2023-04-04 at 11.58.37 AM.png


Screen Shot 2023-04-04 at 12.04.20 PM.png

LizGovier commented 1 year ago

@dimak1

*New Error validation When user clicks Review and Confirm and supporting documents have yet to be selected show :

Figma File Screen Shot 2023-04-13 at 9.38.35 AM.png

dimak1 commented 1 year ago

@LizGovier as discussed about Supporting Document validations, the above screenshot should be updated. Thanks!

dimak1 commented 1 year ago

This is now available in DEV. Please also do a quick check of other Transfer flows. Thanks! cc: @tlebedovich @LizGovier

tlebedovich commented 1 year ago

@saragunnarsson - i think myself and @LizGovier will do the UXA review for WILL flow/validations for this ticket.

LizGovier commented 1 year ago
LizGovier commented 1 year ago
LizGovier commented 1 year ago

Figma Design Screen Shot 2023-04-13 at 12.37.56 PM.png

Dev Screen Shot 2023-04-13 at 12.36.56 PM.png

LizGovier commented 1 year ago

Figma Design Screen Shot 2023-04-13 at 12.57.48 PM.png

Dev Screen Shot 2023-04-13 at 12.56.10 PM.png****

tlebedovich commented 1 year ago

Declared Value

Screen Shot 2023-04-12 at 9.13.42 PM.png


Additional Name Information (regression since WILL work):

Screen Shot 2023-04-13 at 3 10 05 PM

Screen Shot 2023-04-13 at 3 11 38 PM

dimak1 commented 1 year ago

@LizGovier great findings and absolutely related to the Will Transfers flow. However, they were not in the ticket's scope. Let's wait until UXA is completed and put some of them in a separate ticket.

LizGovier commented 1 year ago

Figma Design Screen Shot 2023-04-13 at 3.07.10 PM.png

Dev Screen Shot 2023-04-13 at 3.05.16 PM.png

LizGovier commented 1 year ago

Screen Shot 2023-04-13 at 3.25.22 PM.png

LizGovier commented 1 year ago

Figma Design Screen Shot 2023-04-13 at 3.29.50 PM.png

Dev Screen Shot 2023-04-13 at 3.29.34 PM.png

LizGovier commented 1 year ago

Figma File Screen Shot 2023-04-13 at 3.41.39 PM.png

DEV Screen Shot 2023-04-13 at 3.42.30 PM.png

LizGovier commented 1 year ago

Hey @dimak1 I've gone through WILL and left you quite a few comments. With AFFE and LETA coming up, it may be good to touch base and chat just so I'm clear on how design should be handed off for dev. Would you have time tomorrow?

Also, I've created a list of validation messages that will be used for all Transfers due to death that might help out with keeping track: https://docs.google.com/spreadsheets/d/1LnHG5EsKedAy6UgOMw9FbnjSS72TNZsxwSPOwlxCdtw/edit#gid=1146918710

dimak1 commented 1 year ago

Thanks @LizGovier yes, we can chat tomorrow about it. And about feedback/validations items too, I have some questions.

Also, please move the following items to a new ticket, as they were not part of the original ticket(s):

Thanks!

dimak1 commented 1 year ago

@LizGovier I will start working on the feedback items, but to move this ticket along, could you take out the Review page and Draft related stuff, please?

LizGovier commented 1 year ago

hey @dimak1

Those items have been moved to https://app.zenhub.com/workspaces/assets-62b64b8b72f4dd0022d33fff/issues/gh/bcgov/entity/15895

dimak1 commented 1 year ago

Hi @LizGovier, to your above comment that you moved the Review items to #15895, I didn't see any comments and updated AC in there?

dimak1 commented 1 year ago

This is ready for another round of UXA, based on feedback, minus the Review page.

LizGovier commented 1 year ago

@dimak1 Cameron mentioned that I should move it to this ticket : https://app.zenhub.com/workspaces/assets-team-space-61426544e7e2ea001d079597/issues/gh/bcgov/entity/15795 Screen Shot 2023-04-18 at 9.41.18 AM.png

tlebedovich commented 1 year ago

@LizGovier - please do your final review of all the feedback above

LizGovier commented 1 year ago

Hey @dimak1

I did a second round of UXA based on the feedback above. I've unchecked the tasks that still need attention. Please reach out if you have questions!

dimak1 commented 1 year ago

Thanks @LizGovier. Besides items for Review and Confirm page (that suppose to be in another ticket), I only see these unchecked items:

Will take a look, thanks

dimak1 commented 1 year ago

@LizGovier addressed two items in upcoming PR, the rest of the feedback (eg Review and Confirm / Remove Message, Register Changes and Pay / Broken) belongs to another ticket.

LizGovier commented 1 year ago

Thanks @dimak1

What ticket are these two in? Screen Shot 2023-04-24 at 11.23.36 AM.png

dimak1 commented 1 year ago

@LizGovier, probably the Review and Confirm page of the Will Transfers. If that ticket has AC defined and already estimated, we'll need a new one.

LizGovier commented 1 year ago

Hey @dimak1

I placed those two items regarding Review and Confirm in the proper ticket #15895

Just one small thing and then we can close this ticket. Could you remove the comma in declared value hint text.

Screen Shot 2023-04-25 at 10.11.19 AM.png

Thanks!

dimak1 commented 1 year ago

Thanks @LizGovier, updated and pushed for review. Once merged, I will let you know.

dimak1 commented 1 year ago

@LizGovier ready for UXA.

LizGovier commented 1 year ago

Thanks @dimak1, just reviewed. This can be closed.

tlebedovich commented 1 year ago

@LizGovier all tickets move to RFQA before being closed :)

chdivyareddy commented 1 year ago

Verified in DEV, just couple validation fixes will create a ticket for it, moving this along.