Closed mstanton1 closed 1 year ago
@dimak1 - just putting the misc UXA we talked about in here for you --
@dimak1
*New Error validation When user clicks Review and Confirm and supporting documents have yet to be selected show :
@LizGovier as discussed about Supporting Document validations, the above screenshot should be updated. Thanks!
This is now available in DEV. Please also do a quick check of other Transfer flows. Thanks! cc: @tlebedovich @LizGovier
@saragunnarsson - i think myself and @LizGovier will do the UXA review for WILL flow/validations for this ticket.
Figma Design
Dev
Figma Design
Dev ****
Declared Value
Additional Name Information (regression since WILL work):
@LizGovier great findings and absolutely related to the Will Transfers flow. However, they were not in the ticket's scope. Let's wait until UXA is completed and put some of them in a separate ticket.
[x] Review and Confirm / Red Validation Bar There should only be one red validation bar tied to the group that is being updated.
[x] Review and Confirm / Validation message / All owners must be deceased
Because an executor has been added to the group, this validation message should only say "All owners must be deceased"
Figma Design
Dev
Figma Design
Dev
Figma File
DEV
Hey @dimak1 I've gone through WILL and left you quite a few comments. With AFFE and LETA coming up, it may be good to touch base and chat just so I'm clear on how design should be handed off for dev. Would you have time tomorrow?
Also, I've created a list of validation messages that will be used for all Transfers due to death that might help out with keeping track: https://docs.google.com/spreadsheets/d/1LnHG5EsKedAy6UgOMw9FbnjSS72TNZsxwSPOwlxCdtw/edit#gid=1146918710
Thanks @LizGovier yes, we can chat tomorrow about it. And about feedback/validations items too, I have some questions.
Also, please move the following items to a new ticket, as they were not part of the original ticket(s):
Thanks!
@LizGovier I will start working on the feedback items, but to move this ticket along, could you take out the Review page and Draft related stuff, please?
hey @dimak1
Those items have been moved to https://app.zenhub.com/workspaces/assets-62b64b8b72f4dd0022d33fff/issues/gh/bcgov/entity/15895
Hi @LizGovier, to your above comment that you moved the Review items to #15895, I didn't see any comments and updated AC in there?
This is ready for another round of UXA, based on feedback, minus the Review page.
@dimak1 Cameron mentioned that I should move it to this ticket : https://app.zenhub.com/workspaces/assets-team-space-61426544e7e2ea001d079597/issues/gh/bcgov/entity/15795
@LizGovier - please do your final review of all the feedback above
Hey @dimak1
I did a second round of UXA based on the feedback above. I've unchecked the tasks that still need attention. Please reach out if you have questions!
Thanks @LizGovier. Besides items for Review and Confirm page (that suppose to be in another ticket), I only see these unchecked items:
Will take a look, thanks
@LizGovier addressed two items in upcoming PR, the rest of the feedback (eg Review and Confirm / Remove Message, Register Changes and Pay / Broken) belongs to another ticket.
Thanks @dimak1
What ticket are these two in?
@LizGovier, probably the Review and Confirm page of the Will Transfers. If that ticket has AC defined and already estimated, we'll need a new one.
Hey @dimak1
I placed those two items regarding Review and Confirm in the proper ticket #15895
Just one small thing and then we can close this ticket. Could you remove the comma in declared value hint text.
Thanks!
Thanks @LizGovier, updated and pushed for review. Once merged, I will let you know.
@LizGovier ready for UXA.
Thanks @dimak1, just reviewed. This can be closed.
@LizGovier all tickets move to RFQA before being closed :)
Verified in DEV, just couple validation fixes will create a ticket for it, moving this along.
Tooltip:
When there is no grant of probate deceased owner in a group and user tries to add a new owner to the table, then the following error message is served:
When the user changes the Transfer type after entering the declared value:
When an owner is deceased and an executor is not added to the group (TIC):
When an owner is deceased and an executor is not added (SO/JT):
When all the owners are deceased in a group and an executor is not added:
When all the owners are deceased in a group and user clicks on the Review & Confirm button without adding an executor:
Executor role tooltip:
Additional Name Information tooltip:
When an executor is added to a group after the owners are deceased:
When the user undo the deceased owner with Grant of probate with will after adding an executor:
When the user clicks on the Review & confirm, executor has been added and living owner remains with no Grant of Probate selected:
Review & Confirm screen:
WILL transfer flow validations