search

bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 58 forks source link

KEYCLOAK - Duplicate last name coming from keycloak for BCEID users #15630

Open seeker25 opened 1 year ago

seeker25 commented 1 year ago

Ops tickets: 2371, 2272

Example from keycloak:

First Name: Go Test

Last Name: Test

only happens with BCEID accounts.

We should probably use the displayName instead and split it into first name / last name by space.

Note: Consideration should be made for Business BCeIDs. Double check that they have a display name

For reference:

https://github.com/bcgov/sso-keycloak/wiki/Identity-Provider-Attribute-Mapping

From Andriy: "it looks like the behavior was changed for both silver and gold (it was different in the past), not sure at what point the behavior changed looking at the sso channel, this was the behavior at least a year ago as well"

pwei1018 commented 1 year ago

I just tested this issue. If people enter the contact information, it will show up the contact first name / last name and not the name show up in keycloak.

image

image

bolyachevets commented 1 year ago

As Patrick pointed out the issue only happens when users don't have their profile filled out, in which case the names are pulled from keycloak. Wiped out last name for BCeID users in test/prod, which resolved the issue in ops-support#2272. Potentially the business logic might be wrong though, and we should not be using BCeID as a source of truth, as there are no constraints on what users can enter when they register (ie., there is no guarantee with basic BCeID we would get a legal name back)

seeker25 commented 1 year ago

Shouldn't we get their name information from the affidavit? BCOL admin should be able to key it in?

jennyschan commented 1 year ago

Reopen the ticket as there are many instances of ICBC users first and last names missing from reports which is causing chaos in their reporting system. It is happening across all of their accounts: 6502, 9371, 11517, 11518, 11519, 12277, 17078.

Per Patrick Wei, this is a known bug. If the BCeID user bypass the name field in contact information page when they are joining the account, the name will be blank in the database.

JohnamLane commented 1 year ago

@AshnaMehta Can you please confirm the exact steps to reproduce this and which steps correct the issue? Above, people are talking about contact info - do they mean Customer Profile ID? Please work with SRE to confirm the correct place for this to be remedied as it seems invalid for a BCeID to arrive without a last name.

JohnamLane commented 1 year ago

@AshnaMehta Can you please confirm the exact steps to reproduce this and which steps correct the issue? Above, people are talking about contact info - do they mean Customer Profile ID? Please work with SRE to confirm the correct place for this to be remedied as it seems invalid for a BCeID to arrive without a last name.

daniwilliamson commented 1 year ago

Please tag me when there are updates so I can update the partner (ICBC). Thx!

pwei1018 commented 1 year ago

@AshnaMehta @JohnamLane How is this ticket going?