Edit UI: create new FF to enable corrections per entity types

bcgov / entity

ServiceBC Registry Team working on Legal Entities

Apache License 2.0

23 stars 58 forks source link

Edit UI: create new FF to enable corrections per entity types #15831

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Currently there is a flag, correction-ui-enabled, that controls whether correction filings are enabled (in Dev/Test/Prod).

Instead, we should have a flag for this filing that controls which entities are allowed.

See #15734 for more details.

[x] create new flag in LD -> supported-correction-entities
[x] add check in Filings UI for starting a correction
[x] delete current flag in code (and its usage)
[x] create new flag in code (and its usage)
[ ] ~archive (delete) the old flag in LD~ added to #15999

jdyck-fw commented 1 year ago

Guidance on this ticket of which corps we allow and when.

[x] Allow BENs and SPs and GPs right away (also CPs)

Future tickets:

BCs, CCs, ULCs at go-live
extra pros at go-live, after the rest

severinbeauvais commented 1 year ago

Note to developer: I have updated the new LaunchDarkly feature flag. Its values are now:

in Dev: BC, BEN, CCC, CP, ULC, GP and SP
in Test: BC, BEN, CCC, CP, ULC, GP and SP
in Prod: BEN, CP, GP and SP only

severinbeauvais commented 1 year ago

Test Notes

Business Filings UI now checks the FF before allowing a correction for the current entity type.
Business Edit UI now checks the FF before allowing a correction for the current entity type.

At the moment, corrections are allowed for all possible entity types in Dev and Test, but we could update the FF temporarily to test without a particular entity type.